Skip to content

lib: remove redundant code from timers.js #3143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 3 commits into from
Closed

lib: remove redundant code from timers.js #3143

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58199b1
lib: remove redundant code, add tests in timers.js
Trott Oct 1, 2015
4271293
fixup: improve test
Trott Oct 6, 2015
17e09ec
typo fix
Trott Oct 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
typo fix
  • Loading branch information
@Trott
Trott committed Oct 6, 2015
commit 17e09ecc8057e92fdbb6ae9360e5df8e04cd78b0
2 changes: 1 addition & 1 deletion test/parallel/test-timers-active.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const common = require('../common');
const assert = require('assert');
const active = require('timers').active;

// active() should not create a timer for these
// active() should create timers for these
var legitTimers = [
{ _idleTimeout: 0 },
{ _idleTimeout: 1 }
Expand Down