Skip to content

stream: reset flowing state if no 'readable' or 'data' listeners. #31036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 5 commits into from
Closed

stream: reset flowing state if no 'readable' or 'data' listeners. #31036

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e70f3f3
stream: reset flowing state if no 'readable' or 'data' listeners.
ronag Dec 20, 2019
1514fb9
fixup: add test
ronag Dec 20, 2019
2a27826
fixup: pasued
ronag Dec 21, 2019
906fd31
fixup: compat paused
ronag Dec 21, 2019
a080fd1
fixup: paused
ronag Dec 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: pasued
  • Loading branch information
@ronag
ronag committed Dec 21, 2019
commit 2a2782644cb3c41c2f23ab0bda3018db1449ff51
6 changes: 3 additions & 3 deletions lib/_stream_readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ function ReadableState(options, stream, isDuplex) {
this.emittedReadable = false;
this.readableListening = false;
this.resumeScheduled = false;
this.paused = true;
this.paused = null;
Comment thread
ronag marked this conversation as resolved.
Outdated

// True if the error was already emitted and should not be thrown again
this.errorEmitted = false;
Expand Down Expand Up @@ -368,7 +368,7 @@ function chunkInvalid(state, chunk) {


Readable.prototype.isPaused = function() {
return this._readableState.flowing === false;
return this._readableState.paused === true;
};

// Backwards compatibility.
Expand Down Expand Up @@ -967,7 +967,7 @@ function updateReadableListening(self) {
const state = self._readableState;
state.readableListening = self.listenerCount('readable') > 0;

if (state.resumeScheduled && !state.paused) {
if (state.resumeScheduled && state.paused === false) {
// Flowing needs to be set to true now, otherwise
// the upcoming resume will not flow.
state.flowing = true;
Expand Down
18 changes: 18 additions & 0 deletions test/parallel/test-stream-readable-pause-and-resume.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

const common = require('../common');
const assert = require('assert');
const { Readable } = require('stream');

let ticks = 18;
Expand Down Expand Up @@ -38,3 +39,20 @@ function readAndPause() {

rs.on('data', ondata);
}

{
const readable = new Readable({
read() {}
});

function read() {}

readable.setEncoding('utf8');
readable.on('readable', read);
readable.removeListener('readable', read);
readable.pause();

process.nextTick(function() {
assert(readable.isPaused()); // Throws.
});
}