Skip to content

stream: reset flowing state if no 'readable' or 'data' listeners. #31036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 5 commits into from
Closed

stream: reset flowing state if no 'readable' or 'data' listeners. #31036

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e70f3f3
stream: reset flowing state if no 'readable' or 'data' listeners.
ronag Dec 20, 2019
1514fb9
fixup: add test
ronag Dec 20, 2019
2a27826
fixup: pasued
ronag Dec 21, 2019
906fd31
fixup: compat paused
ronag Dec 21, 2019
a080fd1
fixup: paused
ronag Dec 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: add test
  • Loading branch information
@ronag
ronag committed Dec 20, 2019
commit 1514fb96b2bd564003e37520aa772463c156c176
19 changes: 19 additions & 0 deletions test/parallel/test-stream-readable-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
'use strict';
const common = require('../common');

const { Readable } = require('stream');

const readable = new Readable({
read() {}
});

function read() {}

readable.setEncoding('utf8');
readable.on('readable', read);
readable.removeListener('readable', read);

process.nextTick(function() {
readable.on('data', common.mustCall());
readable.push('hello');
});