bootstrap: updates the warning and adds test

nodejs · shobhitchittora · Sep 14, 2019 · Sep 15, 2019 · Sep 15, 2019 · Sep 15, 2019
commit c18a0dde1523a69eb644376816bb2b1939d3886a
diff --git a/lib/internal/bootstrap/pre_execution.js b/lib/internal/bootstrap/pre_execution.js
@@ -125,7 +125,9 @@ function setupCoverageHooks(dir) {
     internalBinding('profiler').setCoverageDirectory(coverageDirectory);
     internalBinding('profiler').setSourceMapCacheGetter(sourceMapCacheToObject);
   } catch {
-    process.emitWarning('Profiler is not enabled.', 'Warning');
+    process.emitWarning('The inspector is disabled, ' +
+                        'coverage could not be collected',
+                        'Warning');
   }
   return coverageDirectory;
 }

diff --git a/test/fixtures/v8-coverage/subprocess.js b/test/fixtures/v8-coverage/subprocess.js
@@ -6,3 +6,5 @@ setTimeout(() => {
     const c = 102;
   }
 }, 10);
+
+process.on('warning', console.log);
diff --git a/test/parallel/test-coverage-with-inspector-disabled.js b/test/parallel/test-coverage-with-inspector-disabled.js
@@ -0,0 +1,23 @@
+'use strict';
+
+require('../common');
+const fixtures = require('../common/fixtures');
+
+const assert = require('assert');
+const { spawnSync } = require('child_process');
+const env = Object.assign({}, process.env, { NODE_V8_COVERAGE: '/foo/bar' });
+const childPath = fixtures.path('v8-coverage/subprocess');
+const { status, stderr } = spawnSync(
+  process.execPath,
+  [childPath],
+  { env: env }
+);
+
+const warningMessage = 'The inspector is disabled, ' +
+                        'coverage could not be collected';
+
+assert.strictEqual(status, 0);
+assert.strictEqual(
+  stderr.toString().includes(`Warning: ${warningMessage}`),
+  true
+);
-Original file line number
+Diff line change
@@ Expand Up / @@ -6,3 +6,5 @@ setTimeout(() => { @@
         const c = 102;
       }
     }, 10);
+    process.on('warning', console.log);