Skip to content

bootstrap: adds exception handling for profiler bootstrap #29552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shobhitchittora wants to merge 5 commits into from
Closed

bootstrap: adds exception handling for profiler bootstrap #29552

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f760bc3
bootstrap: adds exception handling for profiler bootstrap
Sep 14, 2019
c18a0dd
bootstrap: updates the warning and adds test
Sep 15, 2019
8a7be6b
bootstrap: return empty string when no cov
Sep 15, 2019
180959e
bootstrap: refactor + skip test on inspector enabled
Sep 15, 2019
bbb315d
bootstrap: removes try-caatch and check for inspector
Sep 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bootstrap: return empty string when no cov
  • Loading branch information
@Trott
Shobhit Chittora authored and Trott committed Sep 23, 2019
commit 8a7be6ba33232bc6b4127624aebaffc74be2845d
1 change: 1 addition & 0 deletions lib/internal/bootstrap/pre_execution.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ function setupCoverageHooks(dir) {
process.emitWarning('The inspector is disabled, ' +
'coverage could not be collected',
'Warning');
return '';
}
Comment thread
shobhitchittora marked this conversation as resolved.
Outdated
return coverageDirectory;
}
Expand Down