Skip to content

[v10.x backport] esm: fix esm load bug #27874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 3 commits into from
Closed

[v10.x backport] esm: fix esm load bug #27874

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef51e92
esm: fix esm load bug
ZYSzys May 13, 2019
6de1849
test: clearing require cache crashes esm loader
aduh95 May 2, 2019
77276a4
Fix line change
aduh95 May 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix line change
  • Loading branch information
@aduh95
aduh95 authored May 26, 2019
commit 77276a4a3708d9709bcad79fc185ad31a1a7e57d
2 changes: 1 addition & 1 deletion lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ Module.prototype.load = function(filename) {
const module = ESMLoader.moduleMap.get(url);
// create module entry at load time to snapshot exports correctly
const exports = this.exports;
if (module !== undefined) { // Called from cjs translator
if (module !== undefined) { // called from cjs translator
if (module.reflect) {
module.reflect.onReady((reflect) => {
reflect.exports.default.set(exports);
Expand Down