Skip to content

[v10.x backport] esm: fix esm load bug #27874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 3 commits into from
Closed

[v10.x backport] esm: fix esm load bug #27874

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef51e92
esm: fix esm load bug
ZYSzys May 13, 2019
6de1849
test: clearing require cache crashes esm loader
aduh95 May 2, 2019
77276a4
Fix line change
aduh95 May 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: clearing require cache crashes esm loader 
This test shows the regression introduced in v11.4.0: clearing out the
require.cache crashes node when using the `--experimental-modules` flag.
Refs: #25482

PR-URL: #25491
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
@aduh95
aduh95 committed May 25, 2019
commit 6de18496568b1283d7e19484b9ca5dcb7608f4e8
11 changes: 11 additions & 0 deletions test/es-module/test-esm-loader-cache-clearing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// Flags: --experimental-modules
'use strict';
require('../common');

const { cache } = require;

Object.keys(cache).forEach((key) => {
delete cache[key];
});
// Require the same module again triggers the crash
require('../common');