Skip to content

http: improve performance for incoming headers #26041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
starkwang wants to merge 4 commits into from
Closed

http: improve performance for incoming headers #26041

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fde1c72
http: improve performance for incoming headers
starkwang Feb 11, 2019
4be7aad
[squash] eslint fix
starkwang Feb 11, 2019
ee03e7a
[squash] removing outdated url in comment
starkwang Feb 11, 2019
da7b53d
[squash] fix typo
starkwang Feb 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[squash] eslint fix
  • Loading branch information
@starkwang
starkwang committed Feb 11, 2019
commit 4be7aadb460d2a6f8f607a1b5098bd4d6c2b7ad2
8 changes: 4 additions & 4 deletions benchmark/_http-benchmarkers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@ class AutocannonBenchmarker {
'-d', options.duration,
'-c', options.connections,
'-j',
'-n'
'-n',
];
for (let field in options.headers) {
args.push('-H', `${field}=${options.headers[field]}`)
for (const field in options.headers) {
args.push('-H', `${field}=${options.headers[field]}`);
}
args.push(`http://127.0.0.1:${options.port}${options.path}`)
args.push(`http://127.0.0.1:${options.port}${options.path}`);
const child = child_process.spawn(this.executable, args);
return child;
}
Expand Down