Skip to content

http2: Fix "ERR_HTTP2_INVALID_CONNECTION_HEADERS" error when adding "connection' into header #23908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sagitsofan wants to merge 22 commits into from
Closed

http2: Fix "ERR_HTTP2_INVALID_CONNECTION_HEADERS" error when adding "connection' into header #23908

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
685d968
lib: http2 compatibility error with connection header
sagitsofan Oct 21, 2018
706d7b0
Update lib/internal/http2/util.js
sagitsofan Oct 26, 2018
56a1ef6
spaces remove
sagitsofan Oct 26, 2018
8492823
spaces remove
sagitsofan Oct 26, 2018
5287044
spaces
sagitsofan Oct 26, 2018
8c83d2c
fix linter
sagitsofan Oct 26, 2018
5c38e7d
move logic into compat.js
sagitsofan Oct 27, 2018
3ef516a
change status variable
sagitsofan Oct 27, 2018
4a3a9b7
delete internal tests
sagitsofan Oct 27, 2018
f158370
singlequote
sagitsofan Oct 27, 2018
3468c74
labeling
sagitsofan Oct 27, 2018
9173cb1
change warning message
sagitsofan Oct 27, 2018
9bedc32
change structure
sagitsofan Oct 31, 2018
0ab7481
change term
sagitsofan Nov 2, 2018
bdf62ce
remove comment
sagitsofan Nov 2, 2018
bc1ba7c
trailers fix
sagitsofan Nov 2, 2018
de389eb
only trailers are supported
sagitsofan Nov 2, 2018
d7fd930
c
sagitsofan Dec 3, 2018
7066aa7
new line
sagitsofan Dec 3, 2018
058a029
added test for the connection header
sagitsofan Dec 15, 2018
56f165c
Merge branch 'master' of https://github.com/nodejs/node into http_compat
sagitsofan Dec 15, 2018
0a3cedc
verify warning is emitted
sagitsofan Dec 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change structure 
check if trailer
  • Loading branch information
@sagitsofan
sagitsofan committed Dec 14, 2018
commit 9bedc323485c90b213f2027b21925ab3de868e1d
9 changes: 6 additions & 3 deletions lib/internal/http2/compat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ function assertValidHeader(name, value) {
err = new ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED();
} else if (value === undefined || value === null) {
err = new ERR_HTTP2_INVALID_HEADER_VALUE(value, name);
} else if (name === constants.HTTP2_HEADER_CONNECTION) {
} else if (!isConnectionHeaderAllowed(name, value)) {
connectionHeaderMessageWarn();
Comment thread
sagitsofan marked this conversation as resolved.
Outdated
}
if (err !== undefined) {
Expand Down Expand Up @@ -93,6 +93,10 @@ function statusMessageWarn() {
}
}

function isConnectionHeaderAllowed(name, value) {
return (name === constants.HTTP2_HEADER_CONNECTION && value === 'trailers');
}

function connectionHeaderMessageWarn() {
if (statusConnectionHeaderWarned === false) {
process.emitWarning(
Expand Down Expand Up @@ -557,8 +561,7 @@ class Http2ServerResponse extends Stream {
name = name.trim().toLowerCase();
assertValidHeader(name, value);

// In case of a `connection` header ignore it
if (name === constants.HTTP2_HEADER_CONNECTION) {
if (!isConnectionHeaderAllowed(name, value)) {
return;
}

Expand Down