Skip to content

http2: Fix "ERR_HTTP2_INVALID_CONNECTION_HEADERS" error when adding "connection' into header #23908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sagitsofan wants to merge 22 commits into from
Closed

http2: Fix "ERR_HTTP2_INVALID_CONNECTION_HEADERS" error when adding "connection' into header #23908

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
685d968
lib: http2 compatibility error with connection header
sagitsofan Oct 21, 2018
706d7b0
Update lib/internal/http2/util.js
sagitsofan Oct 26, 2018
56a1ef6
spaces remove
sagitsofan Oct 26, 2018
8492823
spaces remove
sagitsofan Oct 26, 2018
5287044
spaces
sagitsofan Oct 26, 2018
8c83d2c
fix linter
sagitsofan Oct 26, 2018
5c38e7d
move logic into compat.js
sagitsofan Oct 27, 2018
3ef516a
change status variable
sagitsofan Oct 27, 2018
4a3a9b7
delete internal tests
sagitsofan Oct 27, 2018
f158370
singlequote
sagitsofan Oct 27, 2018
3468c74
labeling
sagitsofan Oct 27, 2018
9173cb1
change warning message
sagitsofan Oct 27, 2018
9bedc32
change structure
sagitsofan Oct 31, 2018
0ab7481
change term
sagitsofan Nov 2, 2018
bdf62ce
remove comment
sagitsofan Nov 2, 2018
bc1ba7c
trailers fix
sagitsofan Nov 2, 2018
de389eb
only trailers are supported
sagitsofan Nov 2, 2018
d7fd930
c
sagitsofan Dec 3, 2018
7066aa7
new line
sagitsofan Dec 3, 2018
058a029
added test for the connection header
sagitsofan Dec 15, 2018
56f165c
Merge branch 'master' of https://github.com/nodejs/node into http_compat
sagitsofan Dec 15, 2018
0a3cedc
verify warning is emitted
sagitsofan Dec 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change term
  • Loading branch information
@sagitsofan
sagitsofan committed Dec 14, 2018
commit 0ab7481a2dd5a64c3cbb7c6ca03e3f40162e38d6
5 changes: 4 additions & 1 deletion lib/internal/http2/compat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,10 @@ function statusMessageWarn() {
}

function isConnectionHeaderAllowed(name, value) {
return (name === constants.HTTP2_HEADER_CONNECTION && value === 'trailers');
if (name !== constants.HTTP2_HEADER_CONNECTION)
return true;
else
return value !== 'trailers';
}

function connectionHeaderMessageWarn() {
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-compat-serverresponse-end.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';

console.log("1111")
const {
mustCall,
mustNotCall,
Expand Down