Skip to content

lib: fix code cache generation, add more tests and enable them by default #23855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 4 commits into from
Closed

lib: fix code cache generation, add more tests and enable them by default #23855

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c87a56
lib: fix code cache generation
joyeecheung Oct 24, 2018
135472a
test: run code cache test by default and test generator
joyeecheung Oct 24, 2018
c95e31e
fixup! lib: fix code cache generation
joyeecheung Oct 29, 2018
def5fc0
fixup! lib: fix code cache generation
joyeecheung Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! lib: fix code cache generation
  • Loading branch information
@joyeecheung
joyeecheung committed Oct 29, 2018
commit c95e31e09ba93993082459acd9ae4ebfff7fbc06
5 changes: 5 additions & 0 deletions lib/internal/bootstrap/cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ const cannotUseCache = [
'internal/bootstrap/node'
].concat(depsModule);

if (process.config.variables.v8_enable_inspector !== 1) {
Copy link
Copy Markdown
Member

@jasnell jasnell Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be worthwhile including a quick comment with these that says why they cannot use the cache, just so it's clear to folks coming along later.

cannotUseCache.push('inspector');
cannotUseCache.push('internal/util/inspector');
}

module.exports = {
cachableBuiltins: Object.keys(NativeModule._source).filter(
(key) => !cannotUseCache.includes(key)
Expand Down