Skip to content

lib: fix code cache generation, add more tests and enable them by default #23855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 4 commits into from
Closed

lib: fix code cache generation, add more tests and enable them by default #23855

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c87a56
lib: fix code cache generation
joyeecheung Oct 24, 2018
135472a
test: run code cache test by default and test generator
joyeecheung Oct 24, 2018
c95e31e
fixup! lib: fix code cache generation
joyeecheung Oct 29, 2018
def5fc0
fixup! lib: fix code cache generation
joyeecheung Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
lib: fix code cache generation 
e7f710c broke the code cache generation since internalBinding
is now passed in through the wrapper and cannot be redeclared.
This patch fixes that.
  • Loading branch information
@joyeecheung
joyeecheung committed Oct 28, 2018
commit 2c87a5654f514b5adcc71656a01323c88b3d510c
2 changes: 1 addition & 1 deletion lib/internal/bootstrap/cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// cannot be tampered with even with --expose-internals

const {
NativeModule, internalBinding
NativeModule
} = require('internal/bootstrap/loaders');

function getCodeCache(id) {
Expand Down