Skip to content

test: add test-benchmark-napi #23585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
forivall wants to merge 7 commits into from
Closed

test: add test-benchmark-napi #23585

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b22ee20
test: add test-benchmark-napi
forivall Oct 12, 2018
c62111c
fixup: for ci
forivall Oct 13, 2018
e7ca5ef
Update test-benchmark-napi.js
Trott Oct 13, 2018
8309f44
fixup: use singlequote for strings (linter)
forivall Oct 13, 2018
81bf8ba
fixup! fixup: use singlequote for strings (linter)
Trott Oct 17, 2018
dd64946
fixup! fixup! fixup: use singlequote for strings (linter)
Trott Oct 19, 2018
8ef164e
fixup! fixup! fixup! fixup: use singlequote for strings (linter)
Trott Oct 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add test-benchmark-napi 
also makes sure that the napi benchmark is built before running jstest

skipped on windows since n-api benchmarks aren't built there yet
  • Loading branch information
@forivall
forivall committed Oct 12, 2018
commit b22ee203cb4e4ad87bd9e5eab6da9948296d84ac
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ v8:
tools/make-v8.sh $(V8_ARCH).$(BUILDTYPE_LOWER) $(V8_BUILD_OPTIONS)

.PHONY: jstest
jstest: build-addons build-addons-napi ## Runs addon tests and JS tests
jstest: build-addons build-addons-napi bench-addons-build ## Runs addon tests and JS tests
Copy link
Copy Markdown
Contributor

@refack refack Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: naming convention is build-addons-<variant>

Copy link
Copy Markdown
Contributor Author

@forivall forivall Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, change the name of the target to "build-addons-bench"?

Copy link
Copy Markdown
Contributor

@refack refack Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build-addons-benchmarks?
After all you write it once, and read it a 1000 times...

Copy link
Copy Markdown
Contributor

@refack refack Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I didn't notice it was already defined...
So probably better to leave it as is.

$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) \
--skip-tests=$(CI_SKIP_TESTS) \
$(CI_JS_SUITES) \
Expand Down
17 changes: 17 additions & 0 deletions test/sequential/test-benchmark-napi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
'use strict';

const common = require('../common');

if (common.isWindows) {
common.skip('vcbuild.bat doesn\'t build the n-api benchmarks yet')
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter fails on this due to the missing semicolon at the end.

}

const runBenchmark = require('../common/benchmark');

runBenchmark('napi',
[
"n=1",
"engine=v8",
"type=String"
],
{ NODEJS_BENCHMARK_ZERO_ALLOWED: 1 });