Skip to content

test: add test-benchmark-napi #23585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
forivall wants to merge 7 commits into from
Closed

test: add test-benchmark-napi #23585

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b22ee20
test: add test-benchmark-napi
forivall Oct 12, 2018
c62111c
fixup: for ci
forivall Oct 13, 2018
e7ca5ef
Update test-benchmark-napi.js
Trott Oct 13, 2018
8309f44
fixup: use singlequote for strings (linter)
forivall Oct 13, 2018
81bf8ba
fixup! fixup: use singlequote for strings (linter)
Trott Oct 17, 2018
dd64946
fixup! fixup! fixup: use singlequote for strings (linter)
Trott Oct 19, 2018
8ef164e
fixup! fixup! fixup! fixup: use singlequote for strings (linter)
Trott Oct 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fixup: use singlequote for strings (linter)
  • Loading branch information
@Trott
Trott committed Oct 17, 2018
commit 81bf8ba22a37cc1621290bf4e479276c56da6ab7
6 changes: 4 additions & 2 deletions benchmark/napi/function_args/napi_binding.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ static napi_value CallWithArray(napi_env env, napi_callback_info info) {
status = napi_get_array_length(env, array, &length);
assert(status == napi_ok);

for (uint32_t i = 0; i < length; ++i) {
uint32_t i;
for (i = 0; i < length; ++i) {
napi_value v;
status = napi_get_element(env, array, i, &v);
assert(status == napi_ok);
Expand Down Expand Up @@ -173,7 +174,8 @@ static napi_value CallWithArguments(napi_env env, napi_callback_info info) {
status = napi_get_value_uint32(env, args[0], &loop);
assert(status == napi_ok);

for (uint32_t i = 1; i < loop; ++i) {
uint32_t i;
for (i = 1; i < loop; ++i) {
assert(i < argc);
status = napi_typeof(env, args[i], types);
assert(status == napi_ok);
Expand Down