Skip to content

build: gyp node_base #23439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
refack wants to merge 9 commits into from
Closed

build: gyp node_base #23439

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
543c1d8
tools: tweak js2c.py
refack Oct 12, 2018
0a17e27
src: fixup for embedding - reduce dependecy
refack Oct 12, 2018
cfa64dc
build: create node_base gyp target
refack Oct 13, 2018
3e230c3
build,src: add PCH to node_base
refack Oct 13, 2018
db60be8
deps,v8: fix gypfile bug
refack Oct 15, 2018
6643da4
build: better deafults for V8
refack Oct 15, 2018
5dbf8d8
build,src,inspector: break includes cycle
refack Oct 28, 2018
b22cc31
build: refacor dtrace & etw build
refack Oct 29, 2018
290a1b3
dontland! windows workaround
refack Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps,v8: fix gypfile bug
  • Loading branch information
@refack
refack committed Nov 5, 2018
commit db60be82eec7a77ff85323a7e08ac6e118f46bad
2 changes: 2 additions & 0 deletions deps/v8/gypfiles/toolchain.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1391,6 +1391,8 @@
],
}],
], # conditions
# Temporary refs: https://github.com/nodejs/node/pull/23801
'defines!': ['ENABLE_HANDLE_ZAPPING',],
}, # Release
}, # configurations
'msvs_disabled_warnings': [
Expand Down