Skip to content

build: gyp node_base #23439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
refack wants to merge 9 commits into from
Closed

build: gyp node_base #23439

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
543c1d8
tools: tweak js2c.py
refack Oct 12, 2018
0a17e27
src: fixup for embedding - reduce dependecy
refack Oct 12, 2018
cfa64dc
build: create node_base gyp target
refack Oct 13, 2018
3e230c3
build,src: add PCH to node_base
refack Oct 13, 2018
db60be8
deps,v8: fix gypfile bug
refack Oct 15, 2018
6643da4
build: better deafults for V8
refack Oct 15, 2018
5dbf8d8
build,src,inspector: break includes cycle
refack Oct 28, 2018
b22cc31
build: refacor dtrace & etw build
refack Oct 29, 2018
290a1b3
dontland! windows workaround
refack Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build: better deafults for V8
  • Loading branch information
@refack
refack committed Nov 5, 2018
commit 6643da4d5ccc6a30f920cd5e1f18a4523ce4dfda
3 changes: 3 additions & 0 deletions common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@
'openssl_no_asm%': 0,
'openssl_fips%': '',

# Default to -O0 for debug builds.
'v8_optimized_debug%': 1,

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.9',
Expand Down
13 changes: 2 additions & 11 deletions node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,19 +244,10 @@
],

# - "C4244: conversion from 'type1' to 'type2', possible loss of data"
# Ususaly safe. Disable for `dep`, enable for `src`
# Disabled for `/deps/`, so re-enable for `/src/`.
'msvs_disabled_warnings!': [4244],

'dependencies': [ '<(node_lib_target_name)' ],
'conditions': [
[ 'node_intermediate_lib_type=="static_library" and node_shared=="true" and OS=="aix"', {
# For AIX, shared lib is linked by static lib and .exp. In the
# case here, the executable needs to link to shared lib.
# Therefore, use 'node_aix_shared' target to generate the
# shared lib and then executable.
'dependencies': [ 'node_aix_shared' ],
}, {
'dependencies': [ '<(node_lib_target_name)' ],
}],
[ 'node_intermediate_lib_type=="static_library" and node_shared=="false"', {
'xcode_settings': {
'OTHER_LDFLAGS': [
Expand Down