Skip to content

Forget closed http2 streams #23134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davedoesdev wants to merge 4 commits into from
Closed

Forget closed http2 streams #23134

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6642cf
Forget closed http2 streams
davedoesdev Sep 27, 2018
7507015
Add comment explaining call to nghttp2_option_set_no_closed_streams
davedoesdev Sep 27, 2018
6467dc1
Issue #23116: Decrease test run time
davedoesdev Sep 28, 2018
4a7367f
Use resume to consume stream in test
davedoesdev Oct 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Forget closed http2 streams 
Fixes: #23116
  • Loading branch information
@davedoesdev
davedoesdev committed Oct 2, 2018
commit f6642cfeae4b143a679918ab0458f70b8d3cf30f
2 changes: 2 additions & 0 deletions src/node_http2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ Http2Scope::~Http2Scope() {
Http2Options::Http2Options(Environment* env, nghttp2_session_type type) {
nghttp2_option_new(&options_);

nghttp2_option_set_no_closed_streams(options_, 1);

// We manually handle flow control within a session in order to
// implement backpressure -- that is, we only send WINDOW_UPDATE
// frames to the remote peer as data is actually consumed by user
Expand Down
58 changes: 58 additions & 0 deletions test/parallel/test-http2-forget-closed-streams.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto) {
common.skip('missing crypto');
}

// Issue #23116
// nghttp2 keeps closed stream structures around in memory (couple of hundred
// bytes each) until a session is closed. It does this to maintain the priority
// tree. However, it limits the number of requests that can be made in a
// session before our memory tracking (correctly) kicks in.
// The fix is to tell nghttp2 to forget about closed streams. We don't make use
// of priority anyway.
// Without the fix, this test fails at ~40k requests with an exception:
// Error [ERR_HTTP2_STREAM_ERROR]: Stream closed with error code
// NGHTTP2_ENHANCE_YOUR_CALM

const http2 = require('http2');
const assert = require('assert');
const { Writable } = require('stream');

const server = http2.createServer();

server.on('session', function(session) {
session.on('stream', function(stream) {
stream.on('end', common.mustCall(function() {
this.respond({
':status': 200
}, {
endStream: true
});
}));
stream.pipe(new Writable({
Copy link
Copy Markdown
Member

@lpinca lpinca Oct 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can't we use stream.resume() instead of piping to a dummy writable?

write(chunk, encoding, cb) {
cb();
}
}));
});
});

server.listen(0, function() {
const client = http2.connect(`http://localhost:${server.address().port}`);

function next(i) {
if (i === 100000) {
client.close();
return server.close();
}
const stream = client.request({ ':method': 'POST' });
stream.on('response', common.mustCall(function(headers) {
assert.strictEqual(headers[':status'], 200);
this.on('close', common.mustCall(() => next(i + 1)));
}));
stream.end();
}

next(0);
});