Skip to content

Forget closed http2 streams #23134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davedoesdev wants to merge 4 commits into from
Closed

Forget closed http2 streams #23134

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6642cf
Forget closed http2 streams
davedoesdev Sep 27, 2018
7507015
Add comment explaining call to nghttp2_option_set_no_closed_streams
davedoesdev Sep 27, 2018
6467dc1
Issue #23116: Decrease test run time
davedoesdev Sep 28, 2018
4a7367f
Use resume to consume stream in test
davedoesdev Oct 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment explaining call to nghttp2_option_set_no_closed_streams
  • Loading branch information
@davedoesdev
davedoesdev committed Oct 2, 2018
commit 750701510b99f2f9efbeee6fa90bf882ac3a619f
2 changes: 2 additions & 0 deletions src/node_http2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ Http2Scope::~Http2Scope() {
Http2Options::Http2Options(Environment* env, nghttp2_session_type type) {
nghttp2_option_new(&options_);

// Make sure closed connections aren't kept around, taking up memory.
// Note that this breaks the priority tree, which we don't use.
nghttp2_option_set_no_closed_streams(options_, 1);

// We manually handle flow control within a session in order to
Expand Down