Skip to content

lib: http server, friendly error messages #22995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sagitsofan wants to merge 19 commits into from
Closed

lib: http server, friendly error messages #22995

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
3fc13ab
improved error message description for the http server
sagitsofan Sep 20, 2018
2184f59
fix linter
sagitsofan Sep 20, 2018
bc84569
lib: improved error message description for the http server binding e…
sagitsofan Sep 21, 2018
abbe6ac
fix test
sagitsofan Sep 21, 2018
c21b1ca
assign errno
sagitsofan Sep 21, 2018
71e6065
fixes
sagitsofan Sep 21, 2018
2b87293
add comments
sagitsofan Sep 21, 2018
8b3c24b
function comments fixes
sagitsofan Oct 6, 2018
0e48313
doc: shorten intro of README.md
Trott Sep 25, 2018
5932fba
doc: improve instructions for verifying binaries
Trott Oct 3, 2018
f414853
doc: shorten pull request wait time to 48 hours
Trott Sep 25, 2018
42dd59d
doc: use backticks around file names in README.md
Trott Oct 6, 2018
7a3b34a
doc: update onboarding task
Trott Oct 6, 2018
141cd23
test: remove internal errorCache property
Trott Oct 7, 2018
e7b03d8
assert: remove internal errorCache property
Trott Oct 7, 2018
c1cf5c6
lib: changed function comment
sagitsofan Oct 9, 2018
5804965
lib: changed function comment
sagitsofan Oct 9, 2018
9f038a5
fix conflicts
sagitsofan Oct 10, 2018
fdb7b3e
revert changes
sagitsofan Oct 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: use backticks around file names in README.md 
Use backticks around `SHASUM256.txt` etc. in README.md.

PR-URL: #23299
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
@Trott @sagitsofan
Trott authored and sagitsofan committed Oct 12, 2018
commit 42dd59d60233f718717f03080889ebabbc0c7edd
12 changes: 2 additions & 10 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,10 @@ _docs_ subdirectory. Version-specific documentation is also at

### Verifying Binaries

Download directories contain a SHASUMS256.txt file with SHA checksums for the
Download directories contain a `SHASUMS256.txt` file with SHA checksums for the
files.

To download SHASUMS256.txt using `curl`:
To download `SHASUMS256.txt` using `curl`:

```console
$ curl -O https://nodejs.org/dist/vx.y.z/SHASUMS256.txt
Expand All @@ -132,17 +132,9 @@ it through `sha256sum` with a command such as:
$ grep node-vx.y.z.tar.gz SHASUMS256.txt | sha256sum -c -
```

<<<<<<< HEAD
For Current and LTS, the GPG detached signature of `SHASUMS256.txt` is in
`SHASUMS256.txt.sig`. You can use it with `gpg` to verify the integrity of
`SHASUM256.txt`. You will first need to import all the GPG keys of individuals
=======
For Current and LTS, the GPG detached signature of SHASUMS256.txt is in
SHASUMS256.txt.sig. You can use it with `gpg` to verify the integrity of
SHASUM256.txt. You will first need to import all the GPG keys of individuals
>>>>>>> doc: improve instructions for verifying binaries
authorized to create releases. They are at the bottom of this README under
[Release Team](#release-team). To import the keys:

```console
$ gpg --keyserver pool.sks-keyservers.net --recv-keys DD8F2338BAE7501E3DD5AC78C273792F7D83545D
Expand Down