Skip to content

lib: http server, friendly error messages #22995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sagitsofan wants to merge 19 commits into from
Closed

lib: http server, friendly error messages #22995

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
3fc13ab
improved error message description for the http server
sagitsofan Sep 20, 2018
2184f59
fix linter
sagitsofan Sep 20, 2018
bc84569
lib: improved error message description for the http server binding e…
sagitsofan Sep 21, 2018
abbe6ac
fix test
sagitsofan Sep 21, 2018
c21b1ca
assign errno
sagitsofan Sep 21, 2018
71e6065
fixes
sagitsofan Sep 21, 2018
2b87293
add comments
sagitsofan Sep 21, 2018
8b3c24b
function comments fixes
sagitsofan Oct 6, 2018
0e48313
doc: shorten intro of README.md
Trott Sep 25, 2018
5932fba
doc: improve instructions for verifying binaries
Trott Oct 3, 2018
f414853
doc: shorten pull request wait time to 48 hours
Trott Sep 25, 2018
42dd59d
doc: use backticks around file names in README.md
Trott Oct 6, 2018
7a3b34a
doc: update onboarding task
Trott Oct 6, 2018
141cd23
test: remove internal errorCache property
Trott Oct 7, 2018
e7b03d8
assert: remove internal errorCache property
Trott Oct 7, 2018
c1cf5c6
lib: changed function comment
sagitsofan Oct 9, 2018
5804965
lib: changed function comment
sagitsofan Oct 9, 2018
9f038a5
fix conflicts
sagitsofan Oct 10, 2018
fdb7b3e
revert changes
sagitsofan Oct 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: remove internal errorCache property 
The internal `assert` modules `errorCache` property is exposed only for
testing. The one test that used it is rewritten here to not use it.

This has the following advantages:

* The test now makes sure that there is an empty cache in a more robust
  way. Instead of relying on the internal implementation of
  `errorCache`, it simply spawns a separate process.
* One less test using the `--expose-internals` flag.

PR-URL: #23304
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information
@Trott @sagitsofan
Trott authored and sagitsofan committed Oct 12, 2018
commit 141cd235576f23a88db50e9a1d73a3393ceb7bbe
4 changes: 2 additions & 2 deletions test/parallel/test-assert-builtins-not-read-from-filesystem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ if (process.argv[2] !== 'child') {
e.emit('hello', false);
} catch (err) {
const frames = err.stack.split('\n');
const [, filename, line, column] = frames[1].match(/\((.+):(\d+):(\d+)\)/);
const [, filename, , ] = frames[1].match(/\((.+):(\d+):(\d+)\)/);
// Spawn a child process to avoid the error having been cached in the assert
// module's `errorCache` Map.

const { output, status, error } =
spawnSync(process.execPath,
[process.argv[1], 'child', filename, line, column],
[process.argv[1], 'child', filename],
{ cwd: tmpdir.path, env: process.env });
assert.ifError(error);
assert.strictEqual(status, 0, `Exit code: ${status}\n${output}`);
Expand Down