Skip to content

v8: replace Buffer with FastBuffer in deserialize #21196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryzokuken wants to merge 4 commits into from
Closed

v8: replace Buffer with FastBuffer in deserialize #21196

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b072d74
v8: replace Buffer with FastBuffer in deserialize
ryzokuken Jun 7, 2018
84414b2
fixup! v8: replace Buffer with FastBuffer in deserialize
ryzokuken Jun 7, 2018
c98b7b1
fixup! v8: replace Buffer with FastBuffer in deserialize
ryzokuken Jun 8, 2018
7e39fd1
fixup! v8: replace Buffer with FastBuffer in deserialize
ryzokuken Jun 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
v8: replace Buffer with FastBuffer in deserialize 
Replace the Buffer constructor with a FastBuffer in v8.deserialize in
order to avoid calling the Buffer constructor and thus triggering a
deprecation warning from code inside the core.

Fixes: #21181
  • Loading branch information
@ryzokuken
ryzokuken committed Jun 7, 2018
commit b072d74162a33e95c99b957265b8178536e5dc05
2 changes: 1 addition & 1 deletion lib/v8.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ const arrayBufferViewTypeToIndex = new Map();
}
}

const bufferConstructorIndex = arrayBufferViewTypes.push(Buffer) - 1;
const bufferConstructorIndex = arrayBufferViewTypes.push(FastBuffer) - 1;

class DefaultSerializer extends Serializer {
constructor() {
Expand Down