-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
Large Page Support for Code Issue: 16198 #21064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
0a76c7e
Initial Large Page (2M) support for node.js
suresh-srinivas fa0e324
Add support for checking if explicitHugePages and transparentHugePage…
suresh-srinivas fdb45cd
Added License headers
suresh-srinivas b7791c2
Get rid of waring messages & code cleanup
suresh-srinivas 6631eea
Protect the large pages under #ifdef NODE_ENABLE_LARGE_CODE_PAGES and…
suresh-srinivas 843089c
Added configure option to enable huge pages
uttampawar 077bc01
Added else clause to set node_use_large_pages=false by default
uttampawar 7bdd9fc
Merge branch 'configure_fixes' into 2M-Pages-For-Code-16198
uttampawar b91de5a
Finished adding checks at appropriate places to handle possible error…
uttampawar 7ef956a
Changed return type for two function from void to int
uttampawar b02e7a9
Fixed lint errors.
uttampawar 2af82b1
Added one more condition check for verify the start address of newly …
uttampawar cae9285
Fixed syntax error due to wring data type. int64 to int64_t
uttampawar 30114b6
Removed explictHugePages code
suresh-srinivas 39e1f0d
Merge branch 'add-checks' into 2M-Pages-For-Code-16198
suresh-srinivas 49cd0de
Merge branch '2M-Pages-For-Code-16198' of https://github.intel.com/DS…
suresh-srinivas 2dd9e8c
Added Large Page Support
suresh-srinivas 51d0f02
Merge branch 'intel-large-pages' of https://github.com/suresh-sriniva…
suresh-srinivas 2f672ee
Update PR based on feedback
suresh-srinivas 31504cc
Addressing the additional PR feedback
suresh-srinivas f998c58
Fix the gypi style issue
suresh-srinivas 9f15cfc
Update with stylistic changes (eg char* instead of char *, IsLargePag…
suresh-srinivas d6de361
Add additional guard so large pages is only under Linux and target_ar…
suresh-srinivas 29c7d13
Style fixes according to the Node C++ Style Guide
suresh-srinivas 9828036
Eliminate ld.script and use implicit script
suresh-srinivas 600cf54
Add #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
suresh-srinivas bf259e2
Fix the test failures
suresh-srinivas f0a6dcb
Add detailed help message to configure --with-largepages
suresh-srinivas 4610793
Fix style issues and created inline functions instead of macros for a…
suresh-srinivas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added License headers
Increased number of Pages to be mapped
- Loading branch information
commit fdb45cd3fcc2989bec11fa2c024720a71f07205e
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,34 @@ | ||
| /* | ||
| Copyright (C) 2018 Intel Corporation | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), | ||
| to deal in the Software without restriction, including without limitation | ||
| the rights to use, copy, modify, merge, publish, distribute, sublicense, | ||
| and/or sell copies of the Software, and to permit persons to whom | ||
| the Software is furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included | ||
| in all copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS | ||
| OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
| THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES | ||
| OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, | ||
| ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE | ||
| OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
|
||
| SPDX-License-Identifier: MIT | ||
| */ | ||
|
|
||
| #ifndef NODE_LARGEPAGE_H_ | ||
| #define NODE_LARGEPAGE_H_ | ||
|
|
||
| namespace node { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be enclosed in #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks I fixed it. |
||
| namespace largepages { | ||
| void map_static_code_to_large_pages(); | ||
| bool isLargePagesEnabled(); | ||
| void map_static_code_to_large_pages(); | ||
| } // namespace largepages | ||
| } // namespace node | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worthwhile to expand the algorithm a bit more - helps later maintainance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure that sounds good. I will add more details.