Skip to content

Large Page Support for Code Issue: 16198 #21064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
suresh-srinivas wants to merge 29 commits into from
Closed

Large Page Support for Code Issue: 16198 #21064

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
0a76c7e
Initial Large Page (2M) support for node.js
suresh-srinivas Mar 23, 2018
fa0e324
Add support for checking if explicitHugePages and transparentHugePage…
suresh-srinivas Mar 26, 2018
fdb45cd
Added License headers
suresh-srinivas Mar 30, 2018
b7791c2
Get rid of waring messages & code cleanup
suresh-srinivas Mar 30, 2018
6631eea
Protect the large pages under #ifdef NODE_ENABLE_LARGE_CODE_PAGES and…
suresh-srinivas Apr 4, 2018
843089c
Added configure option to enable huge pages
uttampawar Apr 9, 2018
077bc01
Added else clause to set node_use_large_pages=false by default
uttampawar Apr 9, 2018
7bdd9fc
Merge branch 'configure_fixes' into 2M-Pages-For-Code-16198
uttampawar Apr 9, 2018
b91de5a
Finished adding checks at appropriate places to handle possible error…
uttampawar May 8, 2018
7ef956a
Changed return type for two function from void to int
uttampawar May 9, 2018
b02e7a9
Fixed lint errors.
uttampawar May 24, 2018
2af82b1
Added one more condition check for verify the start address of newly …
uttampawar May 26, 2018
cae9285
Fixed syntax error due to wring data type. int64 to int64_t
uttampawar May 30, 2018
30114b6
Removed explictHugePages code
suresh-srinivas May 30, 2018
39e1f0d
Merge branch 'add-checks' into 2M-Pages-For-Code-16198
suresh-srinivas May 30, 2018
49cd0de
Merge branch '2M-Pages-For-Code-16198' of https://github.intel.com/DS…
suresh-srinivas May 30, 2018
2dd9e8c
Added Large Page Support
suresh-srinivas May 30, 2018
51d0f02
Merge branch 'intel-large-pages' of https://github.com/suresh-sriniva…
suresh-srinivas May 31, 2018
2f672ee
Update PR based on feedback
suresh-srinivas Jun 1, 2018
31504cc
Addressing the additional PR feedback
suresh-srinivas Jun 3, 2018
f998c58
Fix the gypi style issue
suresh-srinivas Jun 3, 2018
9f15cfc
Update with stylistic changes (eg char* instead of char *, IsLargePag…
suresh-srinivas Jun 4, 2018
d6de361
Add additional guard so large pages is only under Linux and target_ar…
suresh-srinivas Jun 4, 2018
29c7d13
Style fixes according to the Node C++ Style Guide
suresh-srinivas Jun 4, 2018
9828036
Eliminate ld.script and use implicit script
suresh-srinivas Jun 7, 2018
600cf54
Add #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
suresh-srinivas Jun 7, 2018
bf259e2
Fix the test failures
suresh-srinivas Jun 7, 2018
f0a6dcb
Add detailed help message to configure --with-largepages
suresh-srinivas Jun 8, 2018
4610793
Fix style issues and created inline functions instead of macros for a…
suresh-srinivas Jun 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update with stylistic changes (eg char* instead of char *, IsLargePag… 
…eEnabled instead of isLargePageEnabled)
  • Loading branch information
@suresh-srinivas
suresh-srinivas committed Jun 4, 2018
commit 9f15cfcee85890d8ef5e3f1aeeedd2eaca4f714e
2 changes: 1 addition & 1 deletion src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4379,7 +4379,7 @@ int Start(int argc, char** argv) {
CHECK_GT(argc, 0);

#ifdef NODE_ENABLE_LARGE_CODE_PAGES
if (node::isLargePagesEnabled()) {
if (node::IsLargePagesEnabled()) {
if ((node::map_static_code_to_large_pages()) != 0) {
fprintf(stderr, "Reverting to default page size\n");
}
Expand Down
26 changes: 10 additions & 16 deletions src/node_large_page.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ namespace node {
#define PAGE_ALIGN_DOWN(x, a) ((x) & ~((a) - 1))
Copy link
Copy Markdown
Member

@addaleax addaleax Jun 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style nit: these could all be inline functions, right?

Copy link
Copy Markdown
Contributor Author

@suresh-srinivas suresh-srinivas Jun 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Yes fixed them to be inline functions.


struct TextRegion {
char * from;
char * to;
char* from;
char* to;
int total_hugepages;
bool found_text_region;
};
Expand Down Expand Up @@ -105,8 +105,8 @@ struct TextRegion {

if (permission.compare("r-xp") == 0) {
start = reinterpret_cast<unsigned int64_t>(&__nodetext);
char *from = reinterpret_cast<char *>PAGE_ALIGN_UP(start, hps);
char *to = reinterpret_cast<char *>PAGE_ALIGN_DOWN(end, hps);
char* from = reinterpret_cast<char *>PAGE_ALIGN_UP(start, hps);
char* to = reinterpret_cast<char *>PAGE_ALIGN_DOWN(end, hps);

if (from < to) {
size_t size = to - from;
Expand All @@ -120,7 +120,7 @@ struct TextRegion {
return nregion;
Copy link
Copy Markdown
Member

@gireeshpunathil gireeshpunathil Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the frame will be overwritten after return, so the local structure will be stale in the caller?

Copy link
Copy Markdown
Contributor Author

@suresh-srinivas suresh-srinivas Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not returning a pointer to this but the actual structure which will be returned as a copy. So we are ok.

Copy link
Copy Markdown
Member

@gireeshpunathil gireeshpunathil Jun 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for that, my mis-understanding.

}

static bool isTransparentHugePagesEnabled() {
static bool IsTransparentHugePagesEnabled() {
std::ifstream ifs;
Copy link
Copy Markdown
Member

@gireeshpunathil gireeshpunathil Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for using C++ style file I/O and C style elsewhere?

Copy link
Copy Markdown
Contributor Author

@suresh-srinivas suresh-srinivas Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will make it consistent and use C++ everywhere.


ifs.open("/sys/kernel/mm/transparent_hugepage/enabled");
Expand Down Expand Up @@ -163,11 +163,12 @@ struct TextRegion {
__attribute__((__noinline__))
__attribute__((__optimize__("2")))
move_text_region_to_large_pages(struct TextRegion r) {
void *nmem = nullptr, *tmem = nullptr;
void* nmem = nullptr;
void* tmem = nullptr;
int ret = 0;

size_t size = r.to - r.from;
void *start = r.from;
void* start = r.from;

// Allocate temporary region preparing for copy
nmem = mmap(nullptr, size,
Expand All @@ -192,13 +193,6 @@ struct TextRegion {
return -1;
}

if (tmem != start) {
fprintf(stderr, "Unable to allocate hugepages\n");
munmap(nmem, size);
munmap(tmem, size);
return -1;
}

ret = madvise(tmem, size, MADV_HUGEPAGE);
if (ret == -1) {
printSystemError(errno);
Expand Down Expand Up @@ -252,8 +246,8 @@ struct TextRegion {
return -1;
}

bool isLargePagesEnabled() {
return isTransparentHugePagesEnabled();
bool IsLargePagesEnabled() {
return IsTransparentHugePagesEnabled();
}

} // namespace node
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Jun 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit I kinda checked out after the first 100 lines. This file has so many style errors, can you fix those first, please?

Copy link
Copy Markdown
Contributor Author

@suresh-srinivas suresh-srinivas Jun 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you be specific? I ran the make -s lint and fixed all the ones pointed to by that.

Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Jun 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter doesn't catch everything but to name three things:

  1. Inconsistent indentation.
  2. Star leans left in pointers (void* p, not void *p or void * p.)
  3. Casing: IsLargePagesEnabled, not isLargePagesEnabled.

Copy link
Copy Markdown
Contributor Author

@suresh-srinivas suresh-srinivas Jun 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I have updated the PR with 2) and 3). I am using standard indentation of 2 spaces.

Copy link
Copy Markdown
Member

@addaleax addaleax Jun 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suresh-srinivas There’s https://github.com/nodejs/node/blob/master/CPP_STYLE_GUIDE.md that would help a lot with this. Also, comparing with other code in our codebase if you’re unsure. :)

(In particular, we don’t indent code inside namespaces)

Copy link
Copy Markdown
Contributor Author

@suresh-srinivas suresh-srinivas Jun 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@addaleax thanks much. I will look at this and fix styles accordingly.

Copy link
Copy Markdown
Contributor Author

@suresh-srinivas suresh-srinivas Jun 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@addaleax @bnoordhuis @gireeshpunathil fixed the style errors. Let me know if you see anything else.

2 changes: 1 addition & 1 deletion src/node_large_page.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
#define SRC_NODE_LARGE_PAGE_H_

namespace node {
Copy link
Copy Markdown
Contributor

@gabrielschulhof gabrielschulhof Jun 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be enclosed in

#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

Copy link
Copy Markdown
Contributor Author

@suresh-srinivas suresh-srinivas Jun 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I fixed it.

bool isLargePagesEnabled();
bool IsLargePagesEnabled();
int map_static_code_to_large_pages();
} // namespace node

Expand Down