Skip to content

test: add fs/promises filehandle sync() and datasync() tests. #20530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shisama wants to merge 4 commits into from
Closed

test: add fs/promises filehandle sync() and datasync() tests. #20530

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05d5a1b
test: add fs/promises filehandle sync() and datasync() tests.
May 5, 2018
4c72ba1
test: replace fs/promises methods with fs/promises filehandle methods
May 7, 2018
c431fc5
test: fix fs/promises to fs.promises
May 19, 2018
d462d2c
test: remove calling `common.mustCall()` that is unnecessary
Jun 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: replace fs/promises methods with fs/promises filehandle methods 
Replacing fs/promises methods read and write with  fs/promises
filehandle methods.
  • Loading branch information
shisama committed Jun 10, 2018
commit 4c72ba1ed6608afb0bdca7aad231fef8343242a7
6 changes: 3 additions & 3 deletions test/parallel/test-fs-promises-file-handle-sync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const assert = require('assert');
const fixtures = require('../common/fixtures');
const tmpdir = require('../common/tmpdir');

const { access, copyFile, open, read, write } = require('fs/promises');
const { access, copyFile, open } = require('fs/promises');
const path = require('path');

common.crashOnUnhandledRejection();
Expand All @@ -18,8 +18,8 @@ async function validateSync() {
await handle.datasync();
await handle.sync();
const buf = Buffer.from('hello world');
await write(handle, buf);
const ret = await read(handle, Buffer.alloc(11), 0, 11, 0);
await handle.write(buf);
const ret = await handle.read(Buffer.alloc(11), 0, 11, 0);
assert.strictEqual(ret.bytesRead, 11);
assert.deepStrictEqual(ret.buffer, buf);
}
Expand Down