Skip to content

test: add fs/promises filehandle sync() and datasync() tests. #20530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shisama wants to merge 4 commits into from
Closed

test: add fs/promises filehandle sync() and datasync() tests. #20530

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05d5a1b
test: add fs/promises filehandle sync() and datasync() tests.
May 5, 2018
4c72ba1
test: replace fs/promises methods with fs/promises filehandle methods
May 7, 2018
c431fc5
test: fix fs/promises to fs.promises
May 19, 2018
d462d2c
test: remove calling `common.mustCall()` that is unnecessary
Jun 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add fs/promises filehandle sync() and datasync() tests. 
To increase test coverage for fs/promises,
added tests for filehandle.sync and filehandle.datasync.
  • Loading branch information
Masashi Hirano committed Jun 10, 2018
commit 05d5a1b5a4aac211b830a2587a52fef817e1f7d2
27 changes: 27 additions & 0 deletions test/parallel/test-fs-promises-file-handle-sync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const fixtures = require('../common/fixtures');
const tmpdir = require('../common/tmpdir');

const { access, copyFile, open, read, write } = require('fs/promises');
const path = require('path');

common.crashOnUnhandledRejection();

async function validateSync() {
tmpdir.refresh();
const dest = path.resolve(tmpdir.path, 'baz.js');
await copyFile(fixtures.path('baz.js'), dest);
await access(dest, 'r');
const handle = await open(dest, 'r+');
await handle.datasync();
await handle.sync();
const buf = Buffer.from('hello world');
await write(handle, buf);
Copy link
Copy Markdown
Member

@ChALkeR ChALkeR May 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handle.write(buf)?
Same results and coverage, also see #20559.

const ret = await read(handle, Buffer.alloc(11), 0, 11, 0);
Copy link
Copy Markdown
Member

@ChALkeR ChALkeR May 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read(handle → handle.read(? See the comment above.

Copy link
Copy Markdown
Contributor Author

@shisama shisama May 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChALkeR Fixed them. Thanks.

assert.strictEqual(ret.bytesRead, 11);
assert.deepStrictEqual(ret.buffer, buf);
}

validateSync().then(common.mustCall());
Copy link
Copy Markdown
Member

@joyeecheung joyeecheung Jun 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common.mustCall() here seems unnecessary. If anything, common.crashOnUnhandledRejection() above gives a better hint about why it fails.

Copy link
Copy Markdown
Contributor Author

@shisama shisama Jun 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joyeecheung Thanks. Removed common.mustCall().