Skip to content

Increase test coverage for fs/promises.js #19811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
humphd wants to merge 3 commits into from
Closed

Increase test coverage for fs/promises.js #19811

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fffdce1
Increase test coverage for fs/promises.js
humphd Apr 4, 2018
d20bde9
Address review comments
humphd Apr 30, 2018
d1ac66f
Add missing await + async on calls to chmod(), fchmod()
humphd Apr 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Increase test coverage for fs/promises.js
  • Loading branch information
@humphd
humphd committed Apr 30, 2018
commit fffdce1c68ba958a335ac6ac4bc5a01a4ecc4267
34 changes: 32 additions & 2 deletions test/parallel/test-fs-promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,24 +82,44 @@ function verifyStatObject(stat) {
stats = await stat(dest);
verifyStatObject(stats);

stats = await handle.stat();
verifyStatObject(stats);

await fdatasync(handle);
await handle.datasync();
await fsync(handle);
await handle.sync();

const buf = Buffer.from('hello world');

await write(handle, buf);

const ret = await read(handle, Buffer.alloc(11), 0, 11, 0);
assert.strictEqual(ret.bytesRead, 11);
assert.deepStrictEqual(ret.buffer, buf);

const buf2 = Buffer.from('HELLO WORLD');
await handle.write(buf2);
const ret2 = await handle.read(Buffer.alloc(11), 0, 11, 0);
assert.strictEqual(ret2.bytesRead, 11);
assert.deepStrictEqual(ret2.buffer, buf);
Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be compared with buf2?

Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Also, if we reduce magic numbers (like 11 in this case) it would be better.


await chmod(dest, 0o666);
await fchmod(handle, 0o666);
handle.chmod(0o666);
Copy link
Copy Markdown
Member

@TimothyGu TimothyGu Apr 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be awaited?

Copy link
Copy Markdown
Contributor Author

@humphd humphd Apr 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thank you for spotting this. I'll fix.

try {
await fchmod(handle, (0o777 + 1));
Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better, if did this for chmod as well.

} catch (err) {
// mode can't be > 0o777
common.expectsError({
code: 'ERR_OUT_OF_RANGE',
type: RangeError
})(err);
}
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general note: we can actually use the following instead:

assert.rejects(
  // `mode` can't be > 0o777
  () => fchmod(handle, (0o777 + 1)),
  {
    code: 'ERR_OUT_OF_RANGE',
    name: 'RangeError [ERR_OUT_OF_RANGE]'
  }
);


await utimes(dest, new Date(), new Date());

try {
await futimes(handle, new Date(), new Date());
await handle.utimes(new Date(), new Date());
} catch (err) {
// Some systems do not have futimes. If there is an error,
// expect it to be ENOSYS
Expand Down Expand Up @@ -147,6 +167,16 @@ function verifyStatObject(stat) {
await rmdir(newdir);

await mkdtemp(path.resolve(tmpDir, 'FOO'));
try {
await mkdtemp(1);
} catch (err) {
// mkdtemp() expects to get a string prefix.
console.log('err', err);
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you please remove the console.log here?

common.expectsError({
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError
})(err);
}
}

doTest().then(common.mustCall());
Expand Down