Skip to content

Increase test coverage for fs/promises.js #19811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
humphd wants to merge 3 commits into from
Closed

Increase test coverage for fs/promises.js #19811

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fffdce1
Increase test coverage for fs/promises.js
humphd Apr 4, 2018
d20bde9
Address review comments
humphd Apr 30, 2018
d1ac66f
Add missing await + async on calls to chmod(), fchmod()
humphd Apr 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add missing await + async on calls to chmod(), fchmod()
  • Loading branch information
@humphd
humphd committed Apr 30, 2018
commit d1ac66f0bf6af5b9e39cb463a12aed778b77bfa3
8 changes: 4 additions & 4 deletions test/parallel/test-fs-promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,25 +106,25 @@ function verifyStatObject(stat) {

await chmod(dest, 0o666);
await fchmod(handle, 0o666);
handle.chmod(0o666);
await handle.chmod(0o666);

// `mode` can't be > 0o777
assert.rejects(
() => chmod(handle, (0o777 + 1)),
async () => chmod(handle, (0o777 + 1)),
{
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError [ERR_INVALID_ARG_TYPE]'
}
);
assert.rejects(
() => fchmod(handle, (0o777 + 1)),
async () => fchmod(handle, (0o777 + 1)),
{
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError [ERR_OUT_OF_RANGE]'
}
);
assert.rejects(
() => handle.chmod(handle, (0o777 + 1)),
async () => handle.chmod(handle, (0o777 + 1)),
{
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError [ERR_INVALID_ARG_TYPE]'
Expand Down