Skip to content

test: use shorthand properties in tests #18105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tniessen wants to merge 12 commits into from
Closed

test: use shorthand properties in tests #18105

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f064249
test: use shorthand properties in TLS tests
tniessen Jan 11, 2018
a4eaf45
test: use shorthand properties in vm tests
tniessen Jan 11, 2018
554c9c4
test: use shorthand properties in http tests
tniessen Jan 11, 2018
d39d950
test: use shorthand properties in net tests
tniessen Jan 11, 2018
1978be7
test: use shorthand properties in fs tests
tniessen Jan 11, 2018
9fd0673
test: use shorthand properties in https tests
tniessen Jan 11, 2018
3ee47a9
test: use shorthand properties in cluster tests
tniessen Jan 11, 2018
4c506b3
test: use shorthand properties in child_proc tests
tniessen Jan 11, 2018
be4d31b
test: use shorthand properties in zlib test
tniessen Jan 11, 2018
228cd20
test: use shorthand properties in util test
tniessen Jan 11, 2018
5958629
test: use shorthand properties in http2 tests
tniessen Jan 11, 2018
5f7a0b1
test: use shorthand properties in stream2 tests
tniessen Jan 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: use shorthand properties in net tests
  • Loading branch information
@tniessen
tniessen committed Jan 11, 2018
commit d39d950f07c5088a960474ee48d1454dce86c844
2 changes: 1 addition & 1 deletion test/parallel/test-net-connect-options-port.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const net = require('net');
{
// connect({hint}, cb) and connect({hint})
const hints = (dns.ADDRCONFIG | dns.V4MAPPED) + 42;
const hintOptBlocks = doConnect([{ hints: hints }],
const hintOptBlocks = doConnect([{ hints }],
() => common.mustNotCall());
for (const block of hintOptBlocks) {
common.expectsError(block, {
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-net-server-listen-handle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ if (!common.isWindows) { // Windows doesn't support {fd: <n>}
// Test invalid fd
const fd = fs.openSync(__filename, 'r');
net.createServer()
.listen({ fd: fd }, common.mustNotCall())
.listen({ fd }, common.mustNotCall())
.on('error', common.mustCall(function(err) {
assert.strictEqual(String(err), 'Error: listen EINVAL');
this.close();
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-net-server-listen-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function close() { this.close(); }
.on('listening', common.mustCall(close));
}

// Test listen(port, cb) and listen({port: port}, cb) combinations
// Test listen(port, cb) and listen({ port }, cb) combinations
const listenOnPort = [
(port, cb) => net.createServer().listen({ port }, cb),
(port, cb) => net.createServer().listen(port, cb)
Expand Down