Skip to content

test: use shorthand properties in tests #18105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tniessen wants to merge 12 commits into from
Closed

test: use shorthand properties in tests #18105

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f064249
test: use shorthand properties in TLS tests
tniessen Jan 11, 2018
a4eaf45
test: use shorthand properties in vm tests
tniessen Jan 11, 2018
554c9c4
test: use shorthand properties in http tests
tniessen Jan 11, 2018
d39d950
test: use shorthand properties in net tests
tniessen Jan 11, 2018
1978be7
test: use shorthand properties in fs tests
tniessen Jan 11, 2018
9fd0673
test: use shorthand properties in https tests
tniessen Jan 11, 2018
3ee47a9
test: use shorthand properties in cluster tests
tniessen Jan 11, 2018
4c506b3
test: use shorthand properties in child_proc tests
tniessen Jan 11, 2018
be4d31b
test: use shorthand properties in zlib test
tniessen Jan 11, 2018
228cd20
test: use shorthand properties in util test
tniessen Jan 11, 2018
5958629
test: use shorthand properties in http2 tests
tniessen Jan 11, 2018
5f7a0b1
test: use shorthand properties in stream2 tests
tniessen Jan 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: use shorthand properties in stream2 tests
  • Loading branch information
@tniessen
tniessen committed Jan 11, 2018
commit 5f7a0b13070a155bcac9dc998a7700698cc2f1c6
5 changes: 2 additions & 3 deletions test/parallel/test-stream2-readable-wrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ const EE = require('events').EventEmitter;
function runTest(highWaterMark, objectMode, produce) {

const old = new EE();
const r = new Readable({ highWaterMark: highWaterMark,
objectMode: objectMode });
const r = new Readable({ highWaterMark, objectMode });
assert.strictEqual(r, r.wrap(old));

r.on('end', common.mustCall());
Expand Down Expand Up @@ -63,7 +62,7 @@ function runTest(highWaterMark, objectMode, produce) {
}

const w = new Writable({ highWaterMark: highWaterMark * 2,
objectMode: objectMode });
objectMode });
Copy link
Copy Markdown
Member Author

@tniessen tniessen Jan 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the second exception to the described rule, again, feel free to request changes here.

const written = [];
w._write = function(chunk, encoding, cb) {
written.push(chunk);
Expand Down