Skip to content

console: minor console refactoring #17707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 6 commits into from
Closed

console: minor console refactoring #17707

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
26bf70e
console: make error handling engine agnostic
BridgeAR Dec 16, 2017
6145af1
console: make variables and checks stricter
BridgeAR Dec 16, 2017
c511a5d
benchmark: refactor console benchmark
BridgeAR Dec 16, 2017
a4e3aa5
console: order functions and remove \n\n
BridgeAR Dec 16, 2017
2dc5813
doc: remove old console note
BridgeAR Dec 16, 2017
7f65b0b
fixup - address comment
BridgeAR Dec 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup - address comment
  • Loading branch information
@BridgeAR
BridgeAR committed Dec 18, 2017
commit 7f65b0b038edb4030f403dc1bf63bb83df0fa002
23 changes: 5 additions & 18 deletions benchmark/misc/arguments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
'use strict';

const { createBenchmark } = require('../common.js');
const { Writable } = require('stream');
const { format, inherits } = require('util');
const { format } = require('util');

const methods = [
'restAndSpread',
Expand All @@ -16,22 +15,20 @@ const bench = createBenchmark(main, {
n: [1e6]
});

const nullStream = createNullStream();

function usingRestAndSpread(...args) {
nullStream.write(format(...args));
format(...args);
}

function usingRestAndApply(...args) {
nullStream.write(format.apply(null, args));
format.apply(null, args);
}

function usingArgumentsAndApply() {
nullStream.write(format.apply(null, arguments));
format.apply(null, arguments);
}

function usingPredefined() {
nullStream.write(format('part 1', 'part', 2, 'part 3', 'part', 4));
format('part 1', 'part', 2, 'part 3', 'part', 4);
}

function main({ n, method, args }) {
Expand Down Expand Up @@ -60,13 +57,3 @@ function main({ n, method, args }) {
fn('part 1', 'part', 2, 'part 3', 'part', 4);
bench.end(n);
}

function createNullStream() {
// Used to approximate /dev/null
function NullStream() {
Writable.call(this, {});
}
inherits(NullStream, Writable);
NullStream.prototype._write = function() {};
return new NullStream();
}