Skip to content

console: minor console refactoring #17707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 6 commits into from
Closed

console: minor console refactoring #17707

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
26bf70e
console: make error handling engine agnostic
BridgeAR Dec 16, 2017
6145af1
console: make variables and checks stricter
BridgeAR Dec 16, 2017
c511a5d
benchmark: refactor console benchmark
BridgeAR Dec 16, 2017
a4e3aa5
console: order functions and remove \n\n
BridgeAR Dec 16, 2017
2dc5813
doc: remove old console note
BridgeAR Dec 16, 2017
7f65b0b
fixup - address comment
BridgeAR Dec 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
console: make error handling engine agnostic 
Calling write could throw a maximum call stack size error. To make
sure this is not specific to a single engine (version), lazily
populate the correct error message by producing such a error on
demand.
  • Loading branch information
@BridgeAR
BridgeAR committed Dec 16, 2017
commit 26bf70edf47ce90be5c6b58fb68a53e3654708e6
12 changes: 11 additions & 1 deletion lib/console.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ const kCounts = Symbol('counts');
// Track amount of indentation required via `console.group()`.
const kGroupIndent = Symbol('groupIndent');

let MAX_STACK_MESSAGE;

function Console(stdout, stderr, ignoreErrors = true) {
if (!(this instanceof Console)) {
return new Console(stdout, stderr, ignoreErrors);
Expand Down Expand Up @@ -111,9 +113,17 @@ function write(ignoreErrors, stream, string, errorhandler, groupIndent) {

stream.write(string, errorhandler);
} catch (e) {
if (MAX_STACK_MESSAGE === undefined) {
try {
// eslint-disable-next-line no-unused-vars
function a() { a(); }
} catch (err) {
MAX_STACK_MESSAGE = err.message;
}
}
// console is a debugging utility, so it swallowing errors is not desirable
// even in edge cases such as low stack space.
if (e.message === 'Maximum call stack size exceeded')
if (e.message === MAX_STACK_MESSAGE && e.name === 'RangeError')
throw e;
// Sorry, there’s no proper way to pass along the error here.
} finally {
Expand Down