Skip to content

buffer: zero-fill buffer allocated with invalid content #17428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

buffer: zero-fill buffer allocated with invalid content #17428

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4065eb
doc: warn against filling buffer with invalid data
addaleax Dec 2, 2017
19e2e14
buffer: zero-fill buffer allocated with invalid content
addaleax Dec 2, 2017
fcb1524
[squash] apapirovski nit
addaleax Dec 2, 2017
b9b4d29
[squash into first commit] apapirovski nit
addaleax Dec 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash into first commit] apapirovski nit
  • Loading branch information
@addaleax
addaleax committed Dec 2, 2017
commit b9b4d29eba129d5fe909a6d1c70bec850e7db683
2 changes: 1 addition & 1 deletion doc/api/buffer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,7 +1259,7 @@ Example: Fill a `Buffer` with a two-byte character
console.log(Buffer.allocUnsafe(3).fill('\u0222'));
```

If `value` is contains invalid characters, it is truncated; if no valid
If `value` contains invalid characters, it is truncated; if no valid
fill data remains, no filling is performed:

```js
Expand Down