Skip to content

buffer: zero-fill buffer allocated with invalid content #17428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

buffer: zero-fill buffer allocated with invalid content #17428

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4065eb
doc: warn against filling buffer with invalid data
addaleax Dec 2, 2017
19e2e14
buffer: zero-fill buffer allocated with invalid content
addaleax Dec 2, 2017
fcb1524
[squash] apapirovski nit
addaleax Dec 2, 2017
b9b4d29
[squash into first commit] apapirovski nit
addaleax Dec 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: warn against filling buffer with invalid data
  • Loading branch information
@addaleax
addaleax committed Dec 2, 2017
commit a4065ebb7efaa18dbc8aae5360d982bd0ed3c89d
13 changes: 13 additions & 0 deletions doc/api/buffer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1254,6 +1254,19 @@ Example: Fill a `Buffer` with a two-byte character
console.log(Buffer.allocUnsafe(3).fill('\u0222'));
```

If `value` is contains invalid characters, it is truncated; if no valid
Copy link
Copy Markdown
Contributor

@apapirovski apapirovski Dec 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extra 'is' before contains

fill data remains, no filling is performed:

```js
const buf = Buffer.allocUnsafe(5);
// Prints: <Buffer 61 61 61 61 61>
console.log(buf.fill('a'));
// Prints: <Buffer aa aa aa aa aa>
console.log(buf.fill('aazz', 'hex'));
// Prints: <Buffer aa aa aa aa aa>
console.log(buf.fill('zz', 'hex'));
Copy link
Copy Markdown
Member

@lpinca lpinca Dec 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: missing // Prints: ?

Edit: nvm.

Copy link
Copy Markdown
Contributor

@vsemozhetbyt vsemozhetbyt Dec 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the comments cover the next line, not the previous.

Copy link
Copy Markdown
Member

@lpinca lpinca Dec 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I misread, sorry.

```

### buf.includes(value[, byteOffset][, encoding])
<!-- YAML
added: v5.3.0
Expand Down