Skip to content

build: better error message on python fail #17298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
refack wants to merge 3 commits into from
Closed

build: better error message on python fail #17298

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a10eb5
build: better error message on python fail
refack Nov 25, 2017
eb496c4
[fixup] explicit validation section
refack Nov 25, 2017
aa15c27
[fixup] improve cleaning of Release artifacts
refack Nov 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[fixup] explicit validation section
  • Loading branch information
@refack
refack committed Nov 25, 2017
commit eb496c44169da393a552a16d26e63e0bf44e1321
16 changes: 8 additions & 8 deletions vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ set nghttp2_debug=
set link_module=

:next-arg
if "%1"=="" goto args-done
if "%1"=="" goto environment-validate
if /i "%1"=="debug" set config=Debug&goto arg-ok
if /i "%1"=="release" set config=Release&goto arg-ok
if /i "%1"=="clean" set target=Clean&goto arg-ok
Expand Down Expand Up @@ -125,13 +125,7 @@ shift
shift
goto next-arg

:args-done

REM Shortcut for just linting (does not need python)
if "%*"=="lint" (
goto lint-cpp
)

:environment-validate
REM Make sure we can find python
call :run-python --version > NUL
if errorlevel 1 (
Expand All @@ -140,6 +134,12 @@ if errorlevel 1 (
exit /b 1
)


REM Shortcut for just linting (does not need python)
if "%*"=="lint" (
goto lint-cpp
)

if defined build_release (
set config=Release
set package=1
Expand Down