Skip to content

build: better error message on python fail #17298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
refack wants to merge 3 commits into from
Closed

build: better error message on python fail #17298

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a10eb5
build: better error message on python fail
refack Nov 25, 2017
eb496c4
[fixup] explicit validation section
refack Nov 25, 2017
aa15c27
[fixup] improve cleaning of Release artifacts
refack Nov 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[fixup] improve cleaning of Release artifacts
  • Loading branch information
@refack
refack committed Nov 25, 2017
commit aa15c27625501438a2291ff99ba58107eb9e7efd
6 changes: 4 additions & 2 deletions vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ goto next-arg

:environment-validate
REM Make sure we can find python
call :run-python --version > NUL
call :run-python --version > NUL 2>&1
if errorlevel 1 (
echo Could not find python2. More information can be found at
echo https://github.com/nodejs/node/blob/master/BUILDING.md#windows-1
Expand Down Expand Up @@ -176,12 +176,14 @@ if "%i18n_arg%"=="without-intl" set configure_flags=%configure_flags% --without-

if defined config_flags set configure_flags=%configure_flags% %config_flags%

if not "%target%"=="Clean" goto no-clean
if not exist "%~dp0deps\icu" goto no-depsicu
if "%target%"=="Clean" echo deleting %~dp0deps\icu
if "%target%"=="Clean" rmdir /S /Q %~dp0deps\icu
:no-depsicu

if "%target%"=="Clean" rmdir /Q /S "%~dp0%config%\node-v%FULLVERSION%-win-%target_arch%" > nul 2> nul
for /d %%I IN ("%~dp0%config%\node-v*") do rmdir /Q /S "%%I"
:no-clean

if defined noprojgen if defined nobuild if not defined sign if not defined msi goto licensertf

Expand Down