Skip to content

[v8.x backport] src: do not add .domain to promises in VM contexts#16074

Closed
TimothyGu wants to merge 1 commit into
nodejs:v8.x-stagingfrom
TimothyGu:v8.x-15695
Closed

[v8.x backport] src: do not add .domain to promises in VM contexts#16074
TimothyGu wants to merge 1 commit into
nodejs:v8.x-stagingfrom
TimothyGu:v8.x-15695

Conversation

@TimothyGu
Copy link
Copy Markdown
Member

@TimothyGu TimothyGu commented Oct 7, 2017

Backports #15695

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v8.x labels Oct 7, 2017
@TimothyGu
Copy link
Copy Markdown
Member Author

TimothyGu commented Oct 7, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10482/

@TimothyGu
src: do not add .domain to promises in VM contexts
3a7411f 
The promises are still tracked, and their handlers will still execute in
the correct domain. The creation domain is simply hidden.

Backport-PR-URL: REPLACEME
PR-URL: nodejs#15695
Fixes: nodejs#15673
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas pushed a commit that referenced this pull request Oct 23, 2017
@TimothyGu @evanlucas
src: do not add .domain to promises in VM contexts
0b04869 
The promises are still tracked, and their handlers will still execute in
the correct domain. The creation domain is simply hidden.

Backport-PR-URL: #16074
PR-URL: #15695
Fixes: #15673
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@evanlucas
Copy link
Copy Markdown
Contributor

evanlucas commented Oct 23, 2017

Landed in 0b04869. Thanks!

@evanlucas evanlucas closed this Oct 23, 2017
@TimothyGu TimothyGu deleted the v8.x-15695 branch March 26, 2018 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TimothyGu @evanlucas @addaleax @nodejs-github-bot