The promises are still tracked, and their handlers will still execute in the correct domain. The creation domain is now simply hidden, in order to prevent objects from outside from leaking into a VM context.

Fixes (and see more context at): #15673

This is technically a breaking change, as it removes a property from created Promise objects under certain circumstances. However, I would argue that this should be landed as semver-patch, for the following reasons:

• This feature breaks the contract of the VM module that, if one doesn't pass in any objects from the outside, the VM context is fully independent. In other words, it can be a bug of security implications despite the fact that we advertise VM module as not a full sandbox, which is duly noted both in documentation and by @bnoordhuis in Promise's domain property allows escaping VM #15673 (comment).
• The core feature of domains -- preserving information across async boundaries -- is still available even after this PR.
• Domain support for promises was introduced in v8.0.0, which means that most of the ecosystem probably have not yet started using the .domain property on promises.
• Even if they have, the presence of .domain on Promises is inconsistent at best. Right now, the property exists only if it was created in a running domain, which means that modules that do not have control over domains (i.e. pretty much all modules except for the very core of a program) cannot depend on the presence of this property.
• However, once v8.x goes LTS, this behavior will be near impossible to change.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

src