Skip to content

test: general improvements to vm tests #14458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 10 commits into from
Closed

test: general improvements to vm tests #14458

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c884f24
test: improve test-vm-syntax-error-stderr
jasnell Jul 24, 2017
ae2d714
test: improve test-vm-run-in-new-context
jasnell Jul 24, 2017
8e1ef69
test: improve test-vm-run-in-new-context
jasnell Jul 24, 2017
fea0067
test: improve test-vm-new-script-this-context
jasnell Jul 24, 2017
29e2576
test: improve test-vm-new-script-new-context
jasnell Jul 24, 2017
b8f2d88
test: improve test-vm-function-declaration
jasnell Jul 24, 2017
684c01f
test: test-vm-create-and-run-in-context
jasnell Jul 24, 2017
1556d3b
test: improve test-vm-context
jasnell Jul 24, 2017
716a19c
test: improve test-vm-context-async-script
jasnell Jul 24, 2017
3fc4543
[Squash] Address nits
jasnell Jul 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: improve test-vm-new-script-new-context
  • Loading branch information
@jasnell
jasnell committed Aug 1, 2017
commit 29e257672e1b351c80b030fb58dd4527202e56da
8 changes: 4 additions & 4 deletions test/parallel/test-vm-new-script-new-context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ const Script = require('vm').Script;

{
const script = new Script('throw new Error(\'test\');');
assert.throws(function() {
assert.throws(() => {
script.runInNewContext();
}, /^Error: test$/);
}

{
const script = new Script('foo.bar = 5;');
assert.throws(function() {
assert.throws(() => {
script.runInNewContext();
}, /^ReferenceError: foo is not defined$/);
}
Expand Down Expand Up @@ -94,14 +94,14 @@ const Script = require('vm').Script;
script.runInNewContext({ f: f });
assert.strictEqual(f.a, 2);

assert.throws(function() {
assert.throws(() => {
script.runInNewContext();
}, /^ReferenceError: f is not defined$/);
}

{
const script = new Script('');
assert.throws(function() {
assert.throws(() => {
script.runInNewContext.call('\'hello\';');
}, /^TypeError: this\.runInContext is not a function$/);
}