Skip to content

test: general improvements to vm tests #14458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 10 commits into from
Closed

test: general improvements to vm tests #14458

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c884f24
test: improve test-vm-syntax-error-stderr
jasnell Jul 24, 2017
ae2d714
test: improve test-vm-run-in-new-context
jasnell Jul 24, 2017
8e1ef69
test: improve test-vm-run-in-new-context
jasnell Jul 24, 2017
fea0067
test: improve test-vm-new-script-this-context
jasnell Jul 24, 2017
29e2576
test: improve test-vm-new-script-new-context
jasnell Jul 24, 2017
b8f2d88
test: improve test-vm-function-declaration
jasnell Jul 24, 2017
684c01f
test: test-vm-create-and-run-in-context
jasnell Jul 24, 2017
1556d3b
test: improve test-vm-context
jasnell Jul 24, 2017
716a19c
test: improve test-vm-context-async-script
jasnell Jul 24, 2017
3fc4543
[Squash] Address nits
jasnell Jul 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: improve test-vm-context
  • Loading branch information
@jasnell
jasnell committed Aug 1, 2017
commit 1556d3b52b98492e67341509124cb52197cbb363
16 changes: 8 additions & 8 deletions test/parallel/test-vm-context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,29 +27,29 @@ const vm = require('vm');
const Script = vm.Script;
let script = new Script('"passed";');

console.error('run in a new empty context');
// Run in a new empty context
let context = vm.createContext();
let result = script.runInContext(context);
assert.strictEqual('passed', result);

console.error('create a new pre-populated context');
// Create a new pre-populated context
context = vm.createContext({ 'foo': 'bar', 'thing': 'lala' });
assert.strictEqual('bar', context.foo);
assert.strictEqual('lala', context.thing);

console.error('test updating context');
// Test updating context
script = new Script('foo = 3;');
result = script.runInContext(context);
assert.strictEqual(3, context.foo);
assert.strictEqual('lala', context.thing);

// Issue GH-227:
assert.throws(function() {
assert.throws(() => {
vm.runInNewContext('', null, 'some.js');
}, /^TypeError: sandbox must be an object$/);

// Issue GH-1140:
console.error('test runInContext signature');
// Test runInContext signature
let gh1140Exception;
try {
vm.runInContext('throw new Error()', context, 'expected-filename.js');
Expand Down Expand Up @@ -77,7 +77,7 @@ const contextifiedSandboxErrorMsg =
});

// Issue GH-693:
console.error('test RegExp as argument to assert.throws');
// Test RegExp as argument to assert.throws
script = vm.createScript('const assert = require(\'assert\'); assert.throws(' +
'function() { throw "hello world"; }, /hello/);',
'some.js');
Expand All @@ -92,13 +92,13 @@ assert.strictEqual(script.runInContext(ctx), false);

// Error on the first line of a module should
// have the correct line and column number
assert.throws(function() {
assert.throws(() => {
vm.runInContext('throw new Error()', context, {
filename: 'expected-filename.js',
lineOffset: 32,
columnOffset: 123
});
}, function(err) {
}, (err) => {
return /expected-filename\.js:33:130/.test(err.stack);
}, 'Expected appearance of proper offset in Error stack');

Expand Down