Skip to content

async_hooks: fix nested hooks mutation #14143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndreasMadsen wants to merge 7 commits into from
Closed

async_hooks: fix nested hooks mutation #14143

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a4cca58
async_hooks: move restoreTmpHooks call to init
BridgeAR Jul 3, 2017
19890ce
fixup: use fs instead of crypto
BridgeAR Jul 11, 2017
3e5d7ba
async_hooks: fix nested hooks mutation
AndreasMadsen Jul 9, 2017
65d4760
[squash] lint
AndreasMadsen Jul 10, 2017
d04802b
[squash] don't use crypto
AndreasMadsen Jul 10, 2017
0b80a31
[squash] use finally block
AndreasMadsen Jul 10, 2017
cbd1f78
[squash] update comment
AndreasMadsen Jul 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash] update comment
  • Loading branch information
@AndreasMadsen
AndreasMadsen committed Jul 13, 2017
commit cbd1f78646d9f5255f5d0b6dc031498625b5e70f
6 changes: 3 additions & 3 deletions lib/async_hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ const { pushAsyncIds, popAsyncIds } = async_wrap;
// Using var instead of (preferably const) in order to assign
// tmp_active_hooks_array if a hook is enabled/disabled during hook execution.
var active_hooks_array = [];
// Track whether a hook callback is currently being processed. Used to make
// sure active_hooks_array isn't altered in mid execution if another hook is
// added or removed.
// Use a counter to track whether a hook callback is currently being processed.
// Used to make sure active_hooks_array isn't altered in mid execution if
// another hook is added or removed. A counter is used to track nested calls.
var processing_hook = 0;
Copy link
Copy Markdown
Contributor

@trevnorris trevnorris Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly change comment above from simply

Track whether a hook [...]

to something like

Use a counter to track [...] and prevent nested calls [...]

// Use to temporarily store and updated active_hooks_array if the user enables
// or disables a hook while hooks are being processed.
Expand Down