Skip to content

async_hooks: fix nested hooks mutation #14143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndreasMadsen wants to merge 7 commits into from
Closed

async_hooks: fix nested hooks mutation #14143

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a4cca58
async_hooks: move restoreTmpHooks call to init
BridgeAR Jul 3, 2017
19890ce
fixup: use fs instead of crypto
BridgeAR Jul 11, 2017
3e5d7ba
async_hooks: fix nested hooks mutation
AndreasMadsen Jul 9, 2017
65d4760
[squash] lint
AndreasMadsen Jul 10, 2017
d04802b
[squash] don't use crypto
AndreasMadsen Jul 10, 2017
0b80a31
[squash] use finally block
AndreasMadsen Jul 10, 2017
cbd1f78
[squash] update comment
AndreasMadsen Jul 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: use fs instead of crypto
  • Loading branch information
@BridgeAR @AndreasMadsen
BridgeAR authored and AndreasMadsen committed Jul 12, 2017
commit 19890ce78f6114445757169db8a27203e451488d
6 changes: 3 additions & 3 deletions test/parallel/test-async-hooks-enable-recursive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const common = require('../common');
const async_hooks = require('async_hooks');
const crypto = require('crypto');
const fs = require('fs');

const nestedHook = async_hooks.createHook({
init: common.mustCall()
Expand All @@ -14,6 +14,6 @@ async_hooks.createHook({
}, 2)
}).enable();

crypto.randomBytes(1, common.mustCall(() => {
crypto.randomBytes(1, common.mustCall());
fs.access(__filename, common.mustCall(() => {
fs.access(__filename, common.mustCall());
}));