Skip to content

crypto: Deprecate createCipher for createCipheriv #13941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iangcarroll wants to merge 13 commits into from
Closed

crypto: Deprecate createCipher for createCipheriv #13941

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cc8976b
crypto: Deprecate createCipher for createCipheriv
Jun 27, 2017
3d0b5a5
crypto: remove unused mode variable
Jun 27, 2017
1e810d0
crypto: mark createCipher as deprecated
Jul 4, 2017
8f2b81f
crypto: add legacy KDF methods
Jul 4, 2017
7f913ec
crypto: update tests for createCipher
Jul 9, 2017
b7abe64
crypto: fix IV buffer length
Jul 9, 2017
b16018a
crypto: fix removal error
Jul 9, 2017
39a2112
crypto: Fix createCipheriv with null IVs and FIPS mode.
Sep 29, 2017
d0f2778
crypto: fix style issues
Sep 29, 2017
14e0566
doc: add crypto.createCipher deprecation information
Sep 29, 2017
3f0fdb2
crypto: downgrade createCipher deprecation to runtime
Sep 29, 2017
b0fe314
crypto: improve documentation of createCipher changes
Oct 8, 2017
0025983
crypto: improve createCipher testing
Oct 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
crypto: fix IV buffer length
  • Loading branch information
Ian Carroll committed Jul 9, 2017
commit b7abe64573c2240ed1155318f23137343871d367
2 changes: 1 addition & 1 deletion src/node_crypto.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3424,7 +3424,7 @@ void CipherBase::Init(const char* cipher_type,
}

unsigned char key[EVP_MAX_KEY_LENGTH];
unsigned char iv[EVP_MAX_KEY_LENGTH];
unsigned char iv[EVP_MAX_IV_LENGTH];

int key_len = EVP_BytesToKey(cipher_,
EVP_md5(),
Expand Down