Skip to content

crypto: Deprecate createCipher for createCipheriv #13941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iangcarroll wants to merge 13 commits into from
Closed

crypto: Deprecate createCipher for createCipheriv #13941

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cc8976b
crypto: Deprecate createCipher for createCipheriv
Jun 27, 2017
3d0b5a5
crypto: remove unused mode variable
Jun 27, 2017
1e810d0
crypto: mark createCipher as deprecated
Jul 4, 2017
8f2b81f
crypto: add legacy KDF methods
Jul 4, 2017
7f913ec
crypto: update tests for createCipher
Jul 9, 2017
b7abe64
crypto: fix IV buffer length
Jul 9, 2017
b16018a
crypto: fix removal error
Jul 9, 2017
39a2112
crypto: Fix createCipheriv with null IVs and FIPS mode.
Sep 29, 2017
d0f2778
crypto: fix style issues
Sep 29, 2017
14e0566
doc: add crypto.createCipher deprecation information
Sep 29, 2017
3f0fdb2
crypto: downgrade createCipher deprecation to runtime
Sep 29, 2017
b0fe314
crypto: improve documentation of createCipher changes
Oct 8, 2017
0025983
crypto: improve createCipher testing
Oct 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
crypto: improve createCipher testing
  • Loading branch information
Ian Carroll committed Oct 8, 2017
commit 002598332b71bfb7f81cbfcbe0cd986c933a07c6
4 changes: 2 additions & 2 deletions benchmark/crypto/cipher-stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ function main(conf) {
const key = crypto.generateLegacyKey(conf.cipher, alice_secret);
const iv = crypto.generateLegacyIV(conf.cipher, alice_secret);

var alice_cipher = crypto.createCipheriv(conf.cipher, key, iv);
var bob_cipher = crypto.createDecipheriv(conf.cipher, key, iv);
const alice_cipher = crypto.createCipheriv(conf.cipher, key, iv);
const bob_cipher = crypto.createDecipheriv(conf.cipher, key, iv);

var message;
var encoding;
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-crypto-deprecated.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ if (!common.hasFipsCrypto) {
assert.throws(() => {
crypto.createCipher('aes-128-ecb', 'this-should-throw');
}, /not supported in FIPS mode/);
}
}
4 changes: 0 additions & 4 deletions test/parallel/test-crypto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,6 @@ testImmutability(crypto.getCurves);

// Regression tests for #5725: hex input that's not a power of two should
// throw, not assert in C++ land.
if (common.hasFipsCrypto) {

}

assert.throws(function() {
crypto.createCipher('aes192', 'test').update('0', 'hex');
}, common.hasFipsCrypto ? /not supported in FIPS mode/ : /Bad input string/);
Expand Down