Skip to content

tools,test: var to const #13732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
refack merged 7 commits into from
Jul 2, 2017
Merged

tools,test: var to const #13732

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bce27c2
tools: change var to const in ./doc/addon-verify
BridgeAR Jun 19, 2017
0808989
tools: change var to const in ./doc/html
BridgeAR Jun 19, 2017
461049f
tools: change var to const in ./doc/json
BridgeAR Jun 19, 2017
a7e1cee
tools: change var to const in ./doc/preprocess
BridgeAR Jun 19, 2017
ea67c27
tools: change var to const in ./eslint-rules
BridgeAR Jun 19, 2017
a5347c9
tools: change var to const in ./license2rtf
BridgeAR Jun 19, 2017
017122a
test: change var to const in ./common
BridgeAR Jun 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tools: change var to const in ./doc/html 
PR-URL: #13732
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
@BridgeAR @refack
BridgeAR authored and refack committed Jul 2, 2017
commit 0808989d938b53035fb858b0e21e2984e991e7a0
28 changes: 14 additions & 14 deletions tools/doc/html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ module.exports = toHTML;
const STABILITY_TEXT_REG_EXP = /(.*:)\s*(\d)([\s\S]*)/;

// customized heading without id attribute
var renderer = new marked.Renderer();
const renderer = new marked.Renderer();
renderer.heading = function(text, level) {
return '<h' + level + '>' + text + '</h' + level + '>\n';
};
Expand All @@ -42,7 +42,7 @@ marked.setOptions({
});

// TODO(chrisdickinson): never stop vomitting / fix this.
var gtocPath = path.resolve(path.join(
const gtocPath = path.resolve(path.join(
__dirname,
'..',
'..',
Expand All @@ -57,8 +57,8 @@ var gtocData = null;
* opts: input, filename, template, nodeVersion.
*/
function toHTML(opts, cb) {
var template = opts.template;
var nodeVersion = opts.nodeVersion || process.version;
const template = opts.template;
const nodeVersion = opts.nodeVersion || process.version;

if (gtocData) {
return onGtocLoaded();
Expand All @@ -80,7 +80,7 @@ function toHTML(opts, cb) {
}

function onGtocLoaded() {
var lexed = marked.lexer(opts.input);
const lexed = marked.lexer(opts.input);
fs.readFile(template, 'utf8', function(er, template) {
if (er) return cb(er);
render({
Expand Down Expand Up @@ -123,10 +123,10 @@ function render(opts, cb) {
var lexed = opts.lexed;
var filename = opts.filename;
var template = opts.template;
var nodeVersion = opts.nodeVersion || process.version;
const nodeVersion = opts.nodeVersion || process.version;

// get the section
var section = getSection(lexed);
const section = getSection(lexed);

filename = path.basename(filename, '.md');

Expand All @@ -138,7 +138,7 @@ function render(opts, cb) {
buildToc(lexed, filename, function(er, toc) {
if (er) return cb(er);

var id = toID(path.basename(filename));
const id = toID(path.basename(filename));

template = template.replace(/__ID__/g, id);
template = template.replace(/__FILENAME__/g, filename);
Expand Down Expand Up @@ -220,9 +220,9 @@ function parseText(lexed) {
// lists that come right after a heading are what we're after.
function parseLists(input) {
var state = null;
var savedState = [];
const savedState = [];
var depth = 0;
var output = [];
const output = [];
let headingIndex = -1;
let heading = null;

Expand Down Expand Up @@ -353,7 +353,7 @@ function parseYAML(text) {
}

// Syscalls which appear in the docs, but which only exist in BSD / OSX
var BSD_ONLY_SYSCALLS = new Set(['lchmod']);
const BSD_ONLY_SYSCALLS = new Set(['lchmod']);

// Handle references to man pages, eg "open(2)" or "lchmod(2)"
// Returns modified text, with such refs replace with HTML links, for example
Expand All @@ -363,7 +363,7 @@ function linkManPages(text) {
/ ([a-z.]+)\((\d)([a-z]?)\)/gm,
(match, name, number, optionalCharacter) => {
// name consists of lowercase letters, number is a single digit
var displayAs = `${name}(${number}${optionalCharacter})`;
const displayAs = `${name}(${number}${optionalCharacter})`;
if (BSD_ONLY_SYSCALLS.has(name)) {
return ` <a href="https://www.freebsd.org/cgi/man.cgi?query=${name}` +
`&sektion=${number}">${displayAs}</a>`;
Expand All @@ -375,7 +375,7 @@ function linkManPages(text) {
}

function linkJsTypeDocs(text) {
var parts = text.split('`');
const parts = text.split('`');
var i;
var typeMatches;

Expand Down Expand Up @@ -453,7 +453,7 @@ function buildToc(lexed, filename, cb) {
cb(null, toc);
}

var idCounters = {};
const idCounters = {};
function getId(text) {
text = text.toLowerCase();
text = text.replace(/[^a-z0-9]+/g, '_');
Expand Down