Skip to content

tools,test: var to const #13732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
refack merged 7 commits into from
Jul 2, 2017
+65 −67
Merged

tools,test: var to const #13732

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bce27c2
tools: change var to const in ./doc/addon-verify
BridgeAR Jun 19, 2017
0808989
tools: change var to const in ./doc/html
BridgeAR Jun 19, 2017
461049f
tools: change var to const in ./doc/json
BridgeAR Jun 19, 2017
a7e1cee
tools: change var to const in ./doc/preprocess
BridgeAR Jun 19, 2017
ea67c27
tools: change var to const in ./eslint-rules
BridgeAR Jun 19, 2017
a5347c9
tools: change var to const in ./license2rtf
BridgeAR Jun 19, 2017
017122a
test: change var to const in ./common
BridgeAR Jun 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: change var to const in ./common 
PR-URL: #13732
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
@BridgeAR @refack
BridgeAR authored and refack committed Jul 2, 2017
commit 017122a6ec260ade02bba4c26d188709b336c911
3 changes: 1 addition & 2 deletions test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,8 +428,7 @@ exports.allowGlobals = allowGlobals;
function leakedGlobals() {
const leaked = [];

// eslint-disable-next-line no-var
for (var val in global) {
for (const val in global) {
if (!knownGlobals.includes(global[val])) {
leaked.push(val);
}
Expand Down