Skip to content

doc: list macOS as supporting filename argument #13111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chris--young wants to merge 3 commits into from
Closed

doc: list macOS as supporting filename argument #13111

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fee2e8
doc: list macOS as supporting filename argument
May 19, 2017
9bd4012
test: check fs.watch filename on Linux and macOS
May 19, 2017
64884c2
test: fs.watch filename check for Windows & AIX
May 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: check fs.watch filename on Linux and macOS 
Fixes: #13108
  • Loading branch information
Chris Young committed May 21, 2017
commit 9bd40124d7d7bf6f1ddb93ef9092fdfa49f83f95
22 changes: 22 additions & 0 deletions test/parallel/test-fs-watchfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,25 @@ fs.watchFile(enoentFile, {interval: 0}, common.mustCall(function(curr, prev) {
fs.unwatchFile(enoentFile);
}
}, 2));

// Watch events should callback with a filename
if (common.isLinux || common.isOSX) {
Copy link
Copy Markdown
Contributor

@aashil aashil May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add Windows too. You can also add AIX according to @gireeshpunathil's suggestion.

Copy link
Copy Markdown
Contributor

@refack refack May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked, it passes on windows.

const dir = common.tmpDir + '/watch';

fs.mkdir(dir, common.mustCall(function(err) {
assert(!err);
Copy link
Copy Markdown
Contributor

@refack refack May 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could use assert.ifError if (err) assert.fail(err); instead. It will rethrow the error so we know what went wrong.
assert(!err) will just say true != false


fs.watch(dir, common.mustCall(function(eventType, filename) {
this._handle.close();
common.refreshTmpDir();
Copy link
Copy Markdown
Contributor

@refack refack May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the test to pass on Windows you should remove the common.refreshTmpDir();. Don't worry about it, the test harness will take care of it.

assert.strictEqual(filename, 'foo.txt');
}));

fs.writeFile(`${dir}/foo.txt`, 'foo', common.mustCall((err) => {
if (err) {
Copy link
Copy Markdown
Contributor

@refack refack May 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can replace the whole callback with (err) => assert.ifError(err)
Ref: #13092 (comment)

Copy link
Copy Markdown
Contributor

@refack refack May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should replace the whole callback with common.mustCall((err) => {if (err) assert.fail(err)})
Ref: #13115

common.refreshTmpDir();
assert(!err);
}
}));
}));
}