Skip to content

doc: list macOS as supporting filename argument #13111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chris--young wants to merge 3 commits into from
Closed

doc: list macOS as supporting filename argument #13111

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fee2e8
doc: list macOS as supporting filename argument
May 19, 2017
9bd4012
test: check fs.watch filename on Linux and macOS
May 19, 2017
64884c2
test: fs.watch filename check for Windows & AIX
May 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: list macOS as supporting filename argument 
Fixes: #13108
  • Loading branch information
Chris Young committed May 21, 2017
commit 5fee2e89987a0e56230868b020cbd9c693e74fe6
8 changes: 4 additions & 4 deletions doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2405,10 +2405,10 @@ this improves the usability of file watching. This is expected behavior.

<!--type=misc-->

Providing `filename` argument in the callback is only supported on Linux and
Windows. Even on supported platforms, `filename` is not always guaranteed to
be provided. Therefore, don't assume that `filename` argument is always
provided in the callback, and have some fallback logic if it is null.
Providing `filename` argument in the callback is only supported on Linux,
macOS, and Windows. Even on supported platforms, `filename` is not always
guaranteed to be provided. Therefore, don't assume that `filename` argument is
always provided in the callback, and have some fallback logic if it is null.

```js
fs.watch('somedir', (eventType, filename) => {
Expand Down