Skip to content

test: added net.connect lookup type check #11873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucamaraschi wants to merge 4 commits into from
Closed

test: added net.connect lookup type check #11873

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dad21f0
test: added net.connect lookup type check
lucamaraschi Mar 15, 2017
1177ae7
Added @jasnell feedbacks
lucamaraschi Mar 16, 2017
e350432
Removed parenthesis @cjihrig
lucamaraschi Mar 16, 2017
b143d6f
Fixed linting
lucamaraschi Mar 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed linting
  • Loading branch information
@lucamaraschi
lucamaraschi committed Mar 16, 2017
commit b143d6fd2439eae4f2b5b81a3d1344af4efc3c50
8 changes: 4 additions & 4 deletions test/parallel/test-net-options-lookup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,27 +5,27 @@ const net = require('net');

const expectedError = /^TypeError: "lookup" option should be a function$/;

['foobar', 1, {}, []].forEach(input => connectThrows(input));
['foobar', 1, {}, []].forEach((input) => connectThrows(input));
Copy link
Copy Markdown
Member

@lpinca lpinca Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: how about adding other primitives (boolean, undefined, symbol)?


function connectThrows(input) {
const opts = {
host: 'localhost',
port: common.PORT,
lookup: input,
lookup: input
};

assert.throws(function() {
net.connect(opts);
}, expectedError);
}

[() => {}].forEach(input => connectDoesNotThrow(input));
[() => {}].forEach((input) => connectDoesNotThrow(input));

function connectDoesNotThrow(input) {
const opts = {
host: 'localhost',
port: common.PORT,
lookup: input,
lookup: input
};

assert.doesNotThrow(function() {
Expand Down