Skip to content

test: added net.connect lookup type check #11873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucamaraschi wants to merge 4 commits into from
Closed

test: added net.connect lookup type check #11873

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dad21f0
test: added net.connect lookup type check
lucamaraschi Mar 15, 2017
1177ae7
Added @jasnell feedbacks
lucamaraschi Mar 16, 2017
e350432
Removed parenthesis @cjihrig
lucamaraschi Mar 16, 2017
b143d6f
Fixed linting
lucamaraschi Mar 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added @jasnell feedbacks
  • Loading branch information
@lucamaraschi
lucamaraschi committed Mar 16, 2017
commit 1177ae7d77510cfab0fb35b66e63ab232a7293f1
8 changes: 4 additions & 4 deletions test/parallel/test-net-options-lookup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ const net = require('net');

const expectedError = /^TypeError: "lookup" option should be a function$/;

['foobar', 1, {}, []].forEach((input => { connectThrows(input); }))
['foobar', 1, {}, []].forEach((input => connectThrows(input) ));
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Mar 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the extra parens around the arrow function here and on line 22 be removed?


function connectThrows(input) {
var opts = {
const opts = {
host: 'localhost',
port: common.PORT,
lookup: input,
Copy link
Copy Markdown
Member

@mcollina mcollina Mar 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should remove the comma here. Is this passing make lint?

Expand All @@ -19,10 +19,10 @@ function connectThrows(input) {
}, expectedError);
}

[() => {}].forEach((input => { connectDoesNotThrow(input); }))
[() => {}].forEach((input => connectDoesNotThrow(input) ));

function connectDoesNotThrow(input) {
var opts = {
const opts = {
host: 'localhost',
port: common.PORT,
lookup: input,
Copy link
Copy Markdown
Member

@mcollina mcollina Mar 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Expand Down