Skip to content

errors, readline: migrate to use internal/errors.js #11390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
slammayjammay wants to merge 7 commits into from
Closed

errors, readline: migrate to use internal/errors.js #11390

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3bb5126
errors, readline: migrate to use internal/errors.js
slammayjammay Feb 15, 2017
035094c
errors, readline: integrate changes from master
slammayjammay May 24, 2017
7cf13a0
errors: readline: throw more accurate errors
slammayjammay May 24, 2017
88b663f
errors, readline: revert accidental whitespace change
slammayjammay May 31, 2017
9c6045f
errors, readline: avoid contraction in error message
slammayjammay May 31, 2017
c238fb9
errors, readline: fix lint error
slammayjammay May 31, 2017
4041b97
errors, readline: pass tests
slammayjammay May 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
errors, readline: avoid contraction in error message
  • Loading branch information
@slammayjammay
slammayjammay committed Jun 7, 2017
commit 9c6045f7634f0f600cc0023a312002e08c930ed2
1 change: 0 additions & 1 deletion doc/api/errors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,6 @@ found [here][online].
encountered by [`http`][] or [`net`][] -- often a sign that a `socket.end()`
was not properly called.

Copy link
Copy Markdown
Member

@joyeecheung joyeecheung May 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental whitespace change?


<a id="nodejs-error-codes"></a>
## Node.js Error Codes

Expand Down
3 changes: 2 additions & 1 deletion lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,8 @@ E('ERR_INDEX_OUT_OF_RANGE', 'Index out of range');
E('ERR_INVALID_ARG_TYPE', invalidArgType);
E('ERR_INVALID_CALLBACK', 'callback must be a function');
E('ERR_INVALID_FD', (fd) => `"fd" must be a positive integer: ${fd}`);
E('ERR_INVALID_CURSOR_POS', 'Can\'t set cursor row without setting its column');
E('ERR_INVALID_CURSOR_POS',
'Cannot set cursor row without setting its column');
E('ERR_INVALID_FILE_URL_HOST', 'File URL host %s');
E('ERR_INVALID_FILE_URL_PATH', 'File URL path %s');
E('ERR_INVALID_HANDLE_TYPE', 'This handle type cannot be sent');
Expand Down